Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addOnTests by removing --magField (93X) #19667

Merged
merged 1 commit into from Jul 10, 2017

Conversation

Martin-Grunewald
Copy link
Contributor

Fix addOnTests by removing --magField (93X)
Based on CMSSW_9_3_X_2017-07-09-2300
Integration of #19469 requires to remove the hardwired --magField parameter as used in the addOnTests as it points to deprecated field versions. The default from Configuration/StandardSequences/python/MagneticField_cff.py will be used instead.

@namapane
Copy link
Contributor

It would make sense to fix this also in past release series where possible. The fix is proper for any release since 7_4_3.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for master.

It involves the following packages:

Utilities/ReleaseScripts

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21336/console Started: 2017/07/10 22:07

@Martin-Grunewald
Copy link
Contributor Author

@Dr15Jones
please sign - this fixes the recently failing addOnTests in 93X.

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 5e705c2 into cms-sw:master Jul 10, 2017
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants