Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in CMS ROOT6 specific code. The function TypeWithDict::pointerToBase() compared two types for equality by comparing the TypeWithDict pointers. This is a bug, because there can easily be more than one TypeWithDict object for the same type.
The fix is to compare the std::type_info (instead of TypeWithDict) for each of the two types, first by comparing the pointers, and, if the pointers are unequal, comparing the std::type_info's by value.
This fixes one framework unit test that was failing in the ROOT6 branch.