Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for same type #1967

Merged
merged 1 commit into from Jan 8, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jan 8, 2014

This pull request fixes a bug in CMS ROOT6 specific code. The function TypeWithDict::pointerToBase() compared two types for equality by comparing the TypeWithDict pointers. This is a bug, because there can easily be more than one TypeWithDict object for the same type.
The fix is to compare the std::type_info (instead of TypeWithDict) for each of the two types, first by comparing the pointers, and, if the pointers are unequal, comparing the std::type_info's by value.
This fixes one framework unit test that was failing in the ROOT6 branch.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2014

A new Pull Request was created by @wmtan for CMSSW_7_0_ROOT6_X.

Fix check for same type

It involves the following packages:

FWCore/Utilities

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

davidlt added a commit that referenced this pull request Jan 8, 2014
@davidlt davidlt merged commit 3b7f53d into cms-sw:CMSSW_7_0_ROOT6_X Jan 8, 2014
@wmtan wmtan deleted the FixBugInTypeComparison branch January 8, 2014 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants