CTPPS pixel DQM histograms update #19670
Conversation
|
A new Pull Request was created by @popovvp for master. It involves the following packages: DQM/CTPPS @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| @@ -328,19 +346,28 @@ edm::EventSetup const &) | |||
| } | |||
|
|
|||
| //------------------------------------------------------------------------------- | |||
| void CTPPSPixelDQMSource::beginLuminosityBlock(edm::LuminosityBlock const& lumiSeg, | |||
There was a problem hiding this comment.
Please remove both beginLuminosityBlock and endLuminosityBlock.
Add remove current_LS, you can get in analyze(), "event.getLuminosityBlock()" I think.
modify Yaxis title of "ROCs_hits_multiplicity_per_event vs LS" plot
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
@popovvp do you have a back port in 92X of this PR? If not, please create it (based on CMSSW_9_2_5_patch2) so DQM can put it in online production, as requested by Valentina. |
No description provided.