Fix TP ET emulation for ieta=16

[christopheralanwest]

The HCAL trigger primitive emulation currently omits contributions from HEP17 in the HB/HE overlap region of ieta=16 if there is no HBP17 contribution at the same (ieta, iphi). This PR fixes the issue.

The attached plots show the compressed ET in data versus emulation for ieta=16 before and after this fix for a run in which charge is injected into individual channels of HEP17 one at a time.

This PR should have no effect on data or MC samples that do not include an upgraded HE. For MC samples with an upgraded HE, the effect should still be essentially negligible; the fix is needed primarily to resolve spurious data vs. emulation discrepancies.

run297917_ieta16_before_fix.pdf
run297917_ieta16_after_fix.pdf

[cmsbuild]

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

SimCalorimetry/HcalTrigPrimAlgos

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[rekovic]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21394/console Started: 2017/07/12 14:54

[cmsbuild]

+1
Tested at: 74720be
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19679/21394/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
de56eaa
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19679/21394/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19679/21394/git-merge-result

[cmsbuild]

Comparison job queued.

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19679/21394/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 2015567
• DQMHistoTests: Total failures: 15047
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2000354
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 93 log files, 14 edm output root files, 23 DQM output files