added hep17 folder, 2d eff plots for egammaHLT DQM and Validation #19699

Monophoton · 2017-07-12T08:27:54Z

Added HEP17 folder with plots in /HLT/EgOffline/ folder similar to HLT/EgOffline/Source_Histos/ but for HEP17, HEM17 region and ratio plots.
Also added 2D efficiency plot (EtaVsPhi) per filter efficiency in HLT/HLTEgammaValidation/ directories.
a minor bug fix (not used in code)

cmsbuild · 2017-07-12T08:28:13Z

A new Pull Request was created by @Monophoton for master.

It involves the following packages:

DQMOffline/Trigger
HLTriggerOffline/Egamma

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

mtosi · 2017-07-12T10:39:49Z

DQMOffline/Trigger/interface/EgHLTEgCutCodes.h

-      HLTINVEINVP   =0x00080000,
+      HLTDETAIN     =0x02000000,
+      HLTDPHIIN     =0x04000000,
+      HLTINVEINVP   =0x08000000,
      //flag that if its set, shows the code is invalid


are you sure ?

otherwise they were similar to:
HLTISOLTRKSPHO=0x00020000,
HLTISOLHAD =0x00040000,
HLTISOLEM =0x00080000
I ask Gabi and she also thinks its a bug.

mtosi · 2017-07-12T10:40:23Z

@cmsbuild, please test

cmsbuild · 2017-07-12T10:40:38Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21395/console Started: 2017/07/12 14:58

mtosi · 2017-07-12T11:56:21Z

i simply saw a difference wrt previous version of the code and i would make sure that such update is intended thanks

…

On 12 Jul 2017, at 13:28, Monophoton ***@***.***> wrote: @Monophoton commented on this pull request. In DQMOffline/Trigger/interface/EgHLTEgCutCodes.h: > //hlt quantities that are slightly different to reco - HLTDETAIN =0x00020000, - HLTDPHIIN =0x00040000, - HLTINVEINVP =0x00080000, + HLTDETAIN =0x02000000, + HLTDPHIIN =0x04000000, + HLTINVEINVP =0x08000000, //flag that if its set, shows the code is invalid otherwise they were similar to: HLTISOLTRKSPHO=0x00020000, HLTISOLHAD =0x00040000, HLTISOLEM =0x00080000 I ask Gabi and she also thinks its a bug. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

cmsbuild · 2017-07-12T14:38:34Z

+1
Tested at: a341621
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19699/21395/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
de56eaa
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19699/21395/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19699/21395/git-merge-result

cmsbuild · 2017-07-12T14:38:37Z

Comparison job queued.

cmsbuild · 2017-07-12T16:27:52Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19699/21395/summary.html

Comparison Summary:

You potentially added 58 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 2015567
DQMHistoTests: Total failures: 15044
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2000357
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 93 log files, 14 edm output root files, 23 DQM output files

dmitrijus · 2017-07-13T09:20:18Z

HLTriggerOffline/Egamma/src/EmDQMPostProcessor.cc

+
+  MonitorElement* meOut = ibooker.book2D(outName,titel,num->GetXaxis()->GetNbins(),num->GetXaxis()->GetXmin(),num->GetXaxis()->GetXmax(),num->GetYaxis()->GetNbins(),num->GetYaxis()->GetXmin(),num->GetYaxis()->GetXmax());
+ TH2F* out= meOut->getTH2F();
+  std::cout<<num->GetXaxis()->GetNbins()<<" ,"<<num->GetXaxis()->GetXmin()<<" ,"<<num->GetXaxis()->GetXmax()<<" , "<<num->GetYaxis()->GetNbins()<<" , "<<num->GetYaxis()->GetXmin()<<" , "<<num->GetYaxis()->GetXmax()<<std::endl;


Using std::cout is forbidden! Use LogInfo/LogWarning!

cmsbuild · 2017-07-13T10:08:33Z

Pull request #19699 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again.

Monophoton · 2017-07-13T14:28:00Z

that std::cout was by mistake and left over from a test. Update the commit to remove it.

dmitrijus · 2017-07-14T12:47:17Z

+1

cmsbuild · 2017-10-04T11:21:28Z

+1
Tested at: c8fbfae
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19699/23424/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
575a47c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19699/23424/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19699/23424/git-merge-result

cmsbuild · 2017-10-04T11:21:31Z

Comparison job queued.

cmsbuild · 2017-10-04T12:11:38Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19699/23424/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2761357
DQMHistoTests: Total failures: 267
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2760903
DQMHistoTests: Total skipped: 187
DQMHistoTests: Total Missing objects: 0
Checked 107 log files, 10 edm output root files, 26 DQM output files

sushilchauhan · 2017-10-16T09:38:45Z

something more need to be done from my side?

davidlange6 · 2017-10-16T12:21:25Z

please test
(I think we mainly need to confirm the old tests are stillok)

cmsbuild · 2017-10-16T12:22:27Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23786/console Started: 2017/10/16 14:23

cmsbuild · 2017-10-16T15:11:55Z

+1
Tested at: c8fbfae
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19699/23786/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
8c0f84b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19699/23786/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19699/23786/git-merge-result

cmsbuild · 2017-10-16T15:11:59Z

Comparison job queued.

cmsbuild · 2017-10-16T16:01:14Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19699/23786/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2767139
DQMHistoTests: Total failures: 99
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2766869
DQMHistoTests: Total skipped: 171
DQMHistoTests: Total Missing objects: 0
Checked 107 log files, 10 edm output root files, 26 DQM output files

davidlange6 · 2017-10-17T07:19:34Z

merge

mtosi · 2017-10-17T08:03:36Z

@sushilchauhan, you need the backport in 92x, don't you ?

sushilchauhan · 2017-10-17T08:48:32Z

@mtosi Yes (and I did it earlier), but i was wating to make sure there are no further udates. Right now I am travellling so will do it tomorrow asap.

mtosi · 2017-10-17T08:56:37Z

thanks ! mia

…

On Tue, Oct 17, 2017 at 10:48 AM, Sushil S. Chauhan < ***@***.***> wrote: @mtosi <https://github.com/mtosi> Yes (and I did it earlier), but i was wating to make sure there are no further udates. Right now I am travellling so will do it tomorrow asap. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19699 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEt58zaV2mIp2jmdc6Sb9HYkESEj7oIgks5stGnogaJpZM4OVSku> .

cmsbuild added this to the CMSSW_9_3_X milestone Jul 12, 2017

cmsbuild added comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Jul 12, 2017

mtosi reviewed Jul 12, 2017

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Jul 12, 2017

cmsbuild added tests-approved and removed tests-started labels Jul 12, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 12, 2017

dmitrijus suggested changes Jul 13, 2017

View reviewed changes

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Jul 13, 2017

cmsbuild removed dqm-pending pending-signatures labels Jul 14, 2017

cmsbuild added tests-approved and removed tests-started labels Oct 4, 2017

cmsbuild added comparison-available and removed comparison-pending labels Oct 4, 2017

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Oct 16, 2017

cmsbuild added tests-started and removed tests-pending labels Oct 16, 2017

cmsbuild added tests-approved and removed tests-started labels Oct 16, 2017

cmsbuild added comparison-available and removed comparison-pending labels Oct 16, 2017

cmsbuild added orp-approved and removed orp-pending labels Oct 17, 2017

cmsbuild merged commit f3ffe7a into cms-sw:master Oct 17, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added hep17 folder, 2d eff plots for egammaHLT DQM and Validation #19699

added hep17 folder, 2d eff plots for egammaHLT DQM and Validation #19699

Monophoton commented Jul 12, 2017

cmsbuild commented Jul 12, 2017

mtosi Jul 12, 2017

Monophoton Jul 12, 2017

mtosi commented Jul 12, 2017

cmsbuild commented Jul 12, 2017 •

edited

mtosi commented Jul 12, 2017 via email

cmsbuild commented Jul 12, 2017

cmsbuild commented Jul 12, 2017

cmsbuild commented Jul 12, 2017

dmitrijus Jul 13, 2017

cmsbuild commented Jul 13, 2017

Monophoton commented Jul 13, 2017

dmitrijus commented Jul 14, 2017

cmsbuild commented Oct 4, 2017

cmsbuild commented Oct 4, 2017

cmsbuild commented Oct 4, 2017

sushilchauhan commented Oct 16, 2017

davidlange6 commented Oct 16, 2017

cmsbuild commented Oct 16, 2017 •

edited

cmsbuild commented Oct 16, 2017

cmsbuild commented Oct 16, 2017

cmsbuild commented Oct 16, 2017

davidlange6 commented Oct 17, 2017

mtosi commented Oct 17, 2017

sushilchauhan commented Oct 17, 2017

mtosi commented Oct 17, 2017 via email

added hep17 folder, 2d eff plots for egammaHLT DQM and Validation #19699

added hep17 folder, 2d eff plots for egammaHLT DQM and Validation #19699

Conversation

Monophoton commented Jul 12, 2017

cmsbuild commented Jul 12, 2017

mtosi Jul 12, 2017

Choose a reason for hiding this comment

Monophoton Jul 12, 2017

Choose a reason for hiding this comment

mtosi commented Jul 12, 2017

cmsbuild commented Jul 12, 2017 • edited

mtosi commented Jul 12, 2017 via email

cmsbuild commented Jul 12, 2017

cmsbuild commented Jul 12, 2017

cmsbuild commented Jul 12, 2017

dmitrijus Jul 13, 2017

Choose a reason for hiding this comment

cmsbuild commented Jul 13, 2017

Monophoton commented Jul 13, 2017

dmitrijus commented Jul 14, 2017

cmsbuild commented Oct 4, 2017

cmsbuild commented Oct 4, 2017

cmsbuild commented Oct 4, 2017

sushilchauhan commented Oct 16, 2017

davidlange6 commented Oct 16, 2017

cmsbuild commented Oct 16, 2017 • edited

cmsbuild commented Oct 16, 2017

cmsbuild commented Oct 16, 2017

cmsbuild commented Oct 16, 2017

davidlange6 commented Oct 17, 2017

mtosi commented Oct 17, 2017

sushilchauhan commented Oct 17, 2017

mtosi commented Oct 17, 2017 via email

cmsbuild commented Jul 12, 2017 •

edited

cmsbuild commented Oct 16, 2017 •

edited