Track trigger np 20140109 bfx

[pozzobon]

In TTStubBuilder.h: one bug fix about the effect of requesting max no. stubs/module, one iterator renaming for safer iteration
In AnalyzerClusterStub.cc: reassigned the collections used to calculate the stub finding efficiency.

[cmsbuild]

A new Pull Request was created by @pozzobon for CMSSW_6_2_X_SLHC.

Track trigger np 20140109 bfx

It involves the following packages:

L1Trigger/TrackTrigger

@cmsbuild, @Degano, @mulhearn, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@davidlange6 you are the release manager for this.

[kknb1056]

Tests 3300, 4100, 4400, 4500, 5001, 40001, 50001, 50002, 60001 and 60002 all pass.

Tests 3400, 4502 and 15001 fail at step 2 (counting from zero) with the exception below.
Highly unlikely to be from this pull request and I get it with the current CMSSW_6_2_X_SLHC head (as of this morning). Happy to merge once I've made a few more checks.

----- Begin Fatal Exception 23-Jan-2014 18:51:28 CET-----------------------
An exception of category 'MonitorElement' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'validation_step'
   [2] Calling event method for module SimHitsValidationHcal/'AllSimHitsValidation'
Exception Message:
Method 'void MonitorElement::Fill(double, double, double)' cannot be invoked on monitor element 'Energy_HB'
----- End Fatal Exception -------------------------------------------------

[kknb1056]

merge

Tracked the failures in 3400, 4502 and 15001 to a change in DataFormats/HcalDetId/src/HcalDetId.cc from pull request #2129 (see the comment there). Not relevant to this pull request so happy to merge.

[mark-grimes]

merge

Not sure if Giulio has updated the bots to recognise my new more obvious username yet, so I'll issue the merge command from both.