Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding inactive hit maps #19740

Merged
merged 2 commits into from Jul 17, 2017
Merged

Adding inactive hit maps #19740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc9c205
added inactive hit maps for Offline DQM
folguera Jul 13, 2017
465d4a7
Fix name typo in inactive hit maps
folguera Jul 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions DQM/SiPixelPhase1TrackEfficiency/interface/SiPixelPhase1TrackEfficiency.h
View file
Open in desktop
Expand Up @@ -17,6 +17,7 @@ class SiPixelPhase1TrackEfficiency : public SiPixelPhase1Base {
enum {
VALID,
MISSING,
INACTIVE,
EFFICIENCY,
VERTICES
};
Expand All @@ -29,6 +30,9 @@ class SiPixelPhase1TrackEfficiency : public SiPixelPhase1Base {
edm::EDGetTokenT<edmNew::DetSetVector<SiPixelCluster> > clustersToken_;
edm::EDGetTokenT<reco::TrackCollection> tracksToken_;
edm::EDGetTokenT<reco::VertexCollection> vtxToken_;

bool applyVertexCut_;

};

#endif
26 changes: 24 additions & 2 deletions DQM/SiPixelPhase1TrackEfficiency/python/SiPixelPhase1TrackEfficiency_cfi.py
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@

specs = VPSet(
StandardSpecifications1D_Num,
StandardSpecification2DOccupancy,
StandardSpecification2DProfile_Num,

Specification().groupBy("PXBarrel/PXLayer/Event") #this will produce inclusive counts per Layer/Disk
.reduce("COUNT")
Expand All @@ -24,6 +24,27 @@
)
)

SiPixelPhase1TrackEfficiencyInactive = DefaultHistoTrack.clone(
name = "inactive",
title = "Inactive Hits",
xlabel = "inactive hits",
dimensions = 0,

specs = VPSet(
StandardSpecifications1D_Num,
StandardSpecification2DProfile_Num,

Specification().groupBy("PXBarrel/PXLayer/Event") #this will produce inclusive counts per Layer/Disk
.reduce("COUNT")
.groupBy("PXBarrel/PXLayer")
.save(nbins=100, xmin=0, xmax=100),
Specification().groupBy("PXForward/PXDisk/Event")
.reduce("COUNT")
.groupBy("PXForward/PXDisk/")
.save(nbins=100, xmin=0, xmax=100),
)
)

SiPixelPhase1TrackEfficiencyMissing = DefaultHistoTrack.clone(
name = "missing",
title = "Missing Hits",
Expand All @@ -32,7 +53,7 @@

specs = VPSet(
StandardSpecifications1D_Num,
StandardSpecification2DOccupancy,
StandardSpecification2DProfile_Num,

Specification().groupBy("PXBarrel/PXLayer/Event") #this will produce inclusive counts per Layer/Disk
.reduce("COUNT")
Expand Down Expand Up @@ -79,6 +100,7 @@
SiPixelPhase1TrackEfficiencyConf = cms.VPSet(
SiPixelPhase1TrackEfficiencyValid,
SiPixelPhase1TrackEfficiencyMissing,
SiPixelPhase1TrackEfficiencyInactive,
SiPixelPhase1TrackEfficiencyEfficiency,
SiPixelPhase1TrackEfficiencyVertices
)
Expand Down
22 changes: 17 additions & 5 deletions DQM/SiPixelPhase1TrackEfficiency/src/SiPixelPhase1TrackEfficiency.cc
View file
Open in desktop
Expand Up @@ -19,13 +19,15 @@
#include "DataFormats/TrackReco/interface/Track.h"
#include "DataFormats/TrackerRecHit2D/interface/SiPixelRecHit.h"
#include "DataFormats/VertexReco/interface/Vertex.h"

#include "DataFormats/VertexReco/interface/VertexFwd.h"

SiPixelPhase1TrackEfficiency::SiPixelPhase1TrackEfficiency(const edm::ParameterSet& iConfig) :
SiPixelPhase1Base(iConfig)
{
tracksToken_ = consumes<reco::TrackCollection>(iConfig.getParameter<edm::InputTag>("tracks"));
vtxToken_ = consumes<reco::VertexCollection>(iConfig.getParameter<edm::InputTag>("primaryvertices"));
applyVertexCut_=iConfig.getUntrackedParameter<bool>("VertexCut",true);

}

void SiPixelPhase1TrackEfficiency::analyze(const edm::Event& iEvent, const edm::EventSetup& iSetup) {
Expand All @@ -40,8 +42,10 @@ void SiPixelPhase1TrackEfficiency::analyze(const edm::Event& iEvent, const edm::
iEvent.getByToken( vtxToken_, vertices);

if (!vertices.isValid()) return;

histo[VERTICES].fill(vertices->size(),DetId(0),&iEvent);
if (vertices->size() == 0) return;

if (applyVertexCut_ && vertices->size() == 0) return;

// should be used for weird cuts
//const auto primaryVertex = vertices->at(0);
Expand All @@ -53,6 +57,9 @@ void SiPixelPhase1TrackEfficiency::analyze(const edm::Event& iEvent, const edm::

for (auto const & track : *tracks) {

//this cut is needed to be consisten with residuals calculation
if (applyVertexCut_ && (track.pt() < 0.75 || std::abs( track.dxy(vertices->at(0).position()) ) > 5*track.dxyError())) continue;

bool isBpixtrack = false, isFpixtrack = false;
int nStripHits = 0;

Expand Down Expand Up @@ -91,7 +98,8 @@ void SiPixelPhase1TrackEfficiency::analyze(const edm::Event& iEvent, const edm::

bool isHitValid = hit->getType()==TrackingRecHit::valid;
bool isHitMissing = hit->getType()==TrackingRecHit::missing;

bool isHitInactive = hit->getType()==TrackingRecHit::inactive;

/*
const SiPixelRecHit* pixhit = dynamic_cast<const SiPixelRecHit*>(hit);
const PixelGeomDetUnit* geomdetunit = dynamic_cast<const PixelGeomDetUnit*> ( tracker->idToDet(id) );
Expand Down Expand Up @@ -119,10 +127,14 @@ void SiPixelPhase1TrackEfficiency::analyze(const edm::Event& iEvent, const edm::
histo[MISSING].fill(id, &iEvent);
histo[EFFICIENCY].fill(0, id, &iEvent);
}
if (isHitInactive) {
histo[INACTIVE].fill(id, &iEvent);
}
}
}
histo[VALID ].executePerEventHarvesting(&iEvent);
histo[MISSING].executePerEventHarvesting(&iEvent);
histo[VALID ].executePerEventHarvesting(&iEvent);
histo[MISSING ].executePerEventHarvesting(&iEvent);
histo[INACTIVE].executePerEventHarvesting(&iEvent);
}

DEFINE_FWK_MODULE(SiPixelPhase1TrackEfficiency);
Expand Down