New Interface for E/gamma 2017 Pixel Matching : V2

[Sam-Harper]

backport of #19263

Dear All,

I missed that the master switched from 93X to 92X while the above PR was in progress. We are preping to use this feature online late next week (basically as soon as we are convinced the alignment is good enough to be able to use it). As such, could we back port this PR to a 92X release.

Thanks and sorry for any hassle this causes.
Sam

@Martin-Grunewald as you may not see it as its RECO code but used exclusively in the HLT (for now, the plan is to use it reco eventually)

[cmsbuild]

A new Pull Request was created by @Sam-Harper for CMSSW_9_2_X.

It involves the following packages:

RecoEgamma/EgammaElectronAlgos

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@rafaellopesdesa, @lgray this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21470/console Started: 2017/07/14 13:27

[cmsbuild]

-1

Tested at: a3fffda

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4661813
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19742/21470/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19742/21470/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19742/21470/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

• AddOn:

I found errors in the following addon tests:

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4661813
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19742/21470/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19742/21470/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19742/21470/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 22
• DQMHistoTests: Total histograms compared: 1756574
• DQMHistoTests: Total failures: 15026
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1741382
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 90 log files, 14 edm output root files, 22 DQM output files

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21497/console Started: 2017/07/14 22:13

[cmsbuild]

+1
Tested at: a3fffda
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19742/21497/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4661813
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19742/21497/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19742/21497/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19742/21497/summary.html

Comparison Summary:

• You potentially added 14 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 22
• DQMHistoTests: Total histograms compared: 1756574
• DQMHistoTests: Total failures: 29838
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1726570
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 90 log files, 14 edm output root files, 22 DQM output files

[slava77]

backport of #19263

[slava77]

+1

for #19742 a3fffda

• the same commit as was used for 93X New Interface for E/gamma 2017 Pixel Matching #19263 a3fffda, which was merged for more than two weeks already in 93X
• jenkins tests pass and comparisons show no differences.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1