Embedding developments: New feature electron embedding and bugfixes #19771
Conversation
|
@perahrens, CMSSW_9_3_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
|
A new Pull Request was created by @perahrens for master. It involves the following packages: GeneratorInterface/Core @efeyazgan, @perrozzi, @civanch, @mdhildreth, @monttj, @cmsbuild, @thuer, @govoni, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
+1 |
|
Pull request #19771 was updated. @efeyazgan, @perrozzi, @civanch, @mdhildreth, @monttj, @cmsbuild, @thuer, @govoni, @davidlange6 can you please check and sign again. |
|
@kpedro88 Thank you very much for your support, Now it should be ok I guess. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
+1 |
|
merge |
Presented in RECO AT 14.07.2017.
New feature to enable electron embedding:
Boolean parameter switchToMuonEmbedding replaced by integer parameter particleToEmbed representing the PDGID of the particle to be embedded.
Workaround to keep prunedGenParticles:
New customizer function to keep genParticle collections that are removed in the PAT step on data.
Bugfix in EmbeddingLHEProducer:
Only tau-leptons were added to the LHE product. Now crosschecking with list of allowed particles.
Bugfix in Merge Collections (found after presentation):
First merge the two collections, then save the new collection.
Testcases:
Clone the following repository into your CMSSW_9_2_3patch2 src folder:
git clone https://github.com/perahrens/gc_configs_for_embedding.gitIt contains three test configuration folders:
For testing purposes, you can copy a RAW testfile (/DoubleMuon/Run2017B-v1/RAW) with the name test.root into the respective folder and run:
cmsRun selection.pycmsRun lheprodandcleaning.pycmsRun generator.pycmsRun merging.pyFinal output will be a root file in MINIAOD format with the hybrid events.