Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track trigger np 20140109 win #1979

Merged

Conversation

pozzobon
Copy link

@pozzobon pozzobon commented Jan 9, 2014

Here I included the new stub finding windows for tab2013 and cbc3 emulation algorithms in L1Trigger/TrackTrigger provided by the Lyon group.

If I did it correctly, this pull request includes the changes also of TrackTrigger_NP_20140109_BFX.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2014

A new Pull Request was created by @pozzobon for CMSSW_6_2_X_SLHC.

Track trigger np 20140109 win

It involves the following packages:

Geometry/TrackerGeometryBuilder
L1Trigger/TrackTrigger

@civanch, @Dr15Jones, @ianna, @mdhildreth, @ktf, @cmsbuild, @nclopezo, @Degano, @mulhearn can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@davidlange6 you are the release manager for this.

@ianna
Copy link
Contributor

ianna commented Jan 10, 2014

+1

@kknb1056
Copy link

merge

Tests 3300, 4500, 5001, 50001, 50002, 60001, 60002 all pass.
Tests 3400, 4502, 15001 fail, but tracked that to a change in pull request #2129 (see the comment there).

@mark-grimes
Copy link

merge

Not sure if Giulio has updated the bots to recognise my new more obvious username yet, so I'll issue the merge command from both.

cmsbuild added a commit that referenced this pull request Jan 24, 2014
@cmsbuild cmsbuild merged commit ecf4a7c into cms-sw:CMSSW_6_2_X_SLHC Jan 24, 2014
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Revert "Upgrade Frontier client to version 2.8.14 and pacparser to 1.3.5."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants