use StringFormat::value() instead of operator const std::string &()

[smuzaffar]

For clang IBs we see link errors like

DQMServices/Core/src/DQMNet.cc:(.text+0x32e7): undefined reference to `lat::StringFormat::operator std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&() const'
DQMServices/Core/src/DQMNet.cc:(.text+0x3487): undefined reference to `lat::StringFormat::operator std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&() const'
tmp/slc6_amd64_gcc630/src/DQMServices/Core/src/DQMServicesCore/DQMNet.o: In function `DQMNet::run()':
DQMServices/Core/src/DQMNet.cc:(.text+0x5157): undefined reference to `lat::StringFormat::operator std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&() const'

this PR uses const std::string & StringFormat::value() instead of implicit call to operator const std::string &() to avoid this error.

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

DQMServices/Core

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

In this case we should replace StringFormat with std::string. If agree then we can have something like

-    p->peeraddr = StringFormat("%1:%2")
-                 .arg(peeraddr.hostname())
-                 .arg(peeraddr.port()).value();
+    p->peeraddr = peeraddr.hostname()+":"+std::to_string(peeraddr.port());

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21623/console Started: 2017/07/19 21:14

[cmsbuild]

+1
Tested at: f237945
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19813/21623/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
b5ed5c7
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19813/21623/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19813/21623/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19813/21623/summary.html

Comparison Summary:

• You potentially added 7 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 2310405
• DQMHistoTests: Total failures: 29518
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2280721
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 93 log files, 14 edm output root files, 23 DQM output files