Phase2 - HGCal - Filtering PFRecHits based on SNR threshold

[felicepantaleo]

This PR is another step towards making RealisticSimClusters more realistic.

A HGCRecHit produces a PFRecHit if its energy is above 5 sigma noise.
The quality test is disabled and can be enabled for testing purposes by uncommenting the code in py configuration.
It will be enabled when RealisticSimClusters will be activated.

@malgeri @rovere @cseez @kpedro88 @vandreev11

[cmsbuild]

A new Pull Request was created by @felicepantaleo (Felice Pantaleo) for master.

It involves the following packages:

RecoLocalCalo/HGCalRecProducers
RecoParticleFlow/PFClusterProducer

@perrotta, @cmsbuild, @slava77, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @mmarionncern, @rafaellopesdesa, @kpedro88, @lgray, @cseez, @bachtis, @cbernet, @seemasharmafnal, @pfs this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21614/console Started: 2017/07/19 20:08

[cmsbuild]

-1

Tested at: b3ef853

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
b5ed5c7
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19819/21614/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19819/21614/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19819/21614/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
10042.0 step5

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step5_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
b5ed5c7
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19819/21614/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19819/21614/git-merge-result

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[felicepantaleo]

Is the error connected to the PR?

[perrotta]

please test

@felicepantaleo : validation stuffs in 2017 wfs are unlikely related to this PR...
Let retry launching the tests, hopefully in a cleaner IB

[cmsbuild]

Pull request #19819 was updated. @perrotta, @cmsbuild, @slava77, @kpedro88, @davidlange6 can you please check and sign again.

[perrotta]

please test

[perrotta]

+1
A new class PFRecHitQTestHGCalThresholdSNR is created which allows cutting on signalOverSigmaNoise
Default value is 0: no effect on standard sequences by now

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21774/console Started: 2017/07/26 10:01

[cmsbuild]

+1
Tested at: bea17df
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19819/21774/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
cc98e01
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19819/21774/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19819/21774/git-merge-result

[cmsbuild]

Comparison job queued.

[kpedro88]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

merge

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19819/21774/summary.html

Comparison Summary:

• You potentially added 5 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 2363781
• DQMHistoTests: Total failures: 14625
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2348990
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 93 log files, 14 edm output root files, 23 DQM output files