Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing Pv from MINIAOSIM, the PVs are actually not stored #19822

Merged
merged 1 commit into from Jul 25, 2017

Conversation

perrozzi
Copy link
Contributor

backport of #18083

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 19, 2017

A new Pull Request was created by @perrozzi for CMSSW_8_0_X.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @seemasharmafnal, @JyothsnaKomaragiri this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@perrozzi
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21617/console Started: 2017/07/19 20:23

@slava77
Copy link
Contributor

slava77 commented Jul 19, 2017

backport of #18083

somehow cmsbot does not recognize this in the PR description to set a label.
@smuzaffar is it possible to check the description as well to assign the label?

@smuzaffar
Copy link
Contributor

@slava77 , it does recognize the PR description but one should use backport of #NNNN
for this PR the description is backport of https://github.com/cms-sw/cmssw/pull/18083
anyway, I will fix the bot to recognize full PR url too

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19822/21617/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 16
  • DQMHistoTests: Total histograms compared: 1164369
  • DQMHistoTests: Total failures: 1088
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1163163
  • DQMHistoTests: Total skipped: 118
  • DQMHistoTests: Total Missing objects: 0
  • Checked 63 log files, 14 edm output root files, 16 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jul 20, 2017

+1

for #19822 aeab001

  • technical update to allow runnig PATPackedGenParticleProducer from GEN; no changes to existing workflows
  • jenkins tests pass and comparisons show no differences

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 5faeb46 into cms-sw:CMSSW_8_0_X Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants