CTPPS: updated diamond unpacker for post-TS1 conditions

[forthommel]

backport of #19754

This PR introduces a collection of critical (and urgent) SW changes for 2017 data-taking operations with the diamond detectors:

• new "lite" readout mode unpacking handled properly, allowing to run on high rate conditions (previously limited at ~80 kHz) ; this SW update is fully backward-compatible, but its integration on the Tier-0 is critical before the deployment of the new FED FW
• leading and trailing edges are inverted, following the investigation performed on the signal cable polarities ; this feature will be backported in all useful releases for the next re-reco of previously collected data.

The test in EventFilter/CTPPSRawToDigi/test/test_diamonds_only_cfg.py has been modified to allow to test the new unpacker on a miniDAQ run collected with this new readout mode.

[cmsbuild]

A new Pull Request was created by @forthommel (Laurent Forthomme) for CMSSW_9_2_X.

It involves the following packages:

EventFilter/CTPPSRawToDigi

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

• Backported from CTPPS: updated diamond unpacker for post-TS1 conditions #19754

[slava77]

@cmsbuild please test workflow 136.772,136.780

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21624/console Started: 2017/07/19 21:28

[cmsbuild]

+1
Tested at: cd03087
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19830/21624/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
ae7effd
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19830/21624/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19830/21624/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19830/21624/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 22
• DQMHistoTests: Total histograms compared: 1756428
• DQMHistoTests: Total failures: 29439
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1726823
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 90 log files, 14 edm output root files, 22 DQM output files

[slava77]

+1

for #19830 cd03087

• changes are identical to signed and merged 93X version CTPPS: updated diamond unpacker for post-TS1 conditions #19754 a2ba7c6
• jenkins tests pass and comparisons show no differences (workflows with comparisons do not have CTPPS diamond data); workflows with CTPPS diamond data with the old firmware completed OK (136.772,136.780)
• relying on tests done in 93X to signoff here

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

merge

[threus]

@forthommel could you please make a new PR in 92X, but based on CMSSW_9_2_5_patch2 so that it can be put to online DQM in production, as requested by Valentina? Once you submit the new PR, please close it immediately, so it won't be considered for merging, only for online DQM (no need for that, since this PR is already merged).

[davidlange6]

sorry - please make such PRs somewhere else... Thanks

…

On Jul 21, 2017, at 11:27 AM, threus ***@***.***> wrote: @forthommel could you please make a new PR in 92X, but based on CMSSW_9_2_5_patch2 so that it can be put to online DQM in production, as requested by Valentina? Once you submit the new PR, please close it immediately, so it won't be considered for merging, only for online DQM (no need for that, since this PR is already merged). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[forthommel]

Hi @threus, @davidlange6,
Would the CMSSW_9_2_3_patchX branch be a more fitting space?

[threus]

@davidlange6 of course I meant another PR, definitely not to modify this one. It's merged anyway.

[forthommel]

Alternatively, I guess a git cms-merge-topic forthommel:ctpps-diamond_unpacker_after2017TS1-9_2_5_patch2 could also work if that can fit in your workspace, @threus !

[forthommel]

Oh, sure! I can definitely launch a new PR in 9_2_X right away then!

[forthommel]

#19852

[davidlange6]

Right - and I really mean some other repo/branch. If DQM has needs not met they should raise them with the release team rather than making a mess of branches in the CMSSW repo.

…

On Jul 21, 2017, at 11:31 AM, threus ***@***.***> wrote: @davidlange6 of course I meant another PR, definitely not to modify this one. It's merged anyway. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[threus]

@davidlange6 ok understood. #19852 suits the needs and it's closed now, not to use further resources. Next time we (DQM) will ask to back port in a different branch, as you suggest.