Run2-sim15 Handle the depth word correctly and use 2 lowest bit to store information crystal/APD #19867
Conversation
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: SimCalorimetry/EcalSimAlgos @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@bsunanda, you likely forget debug cout, would you expect any difference in comparison? |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #19867 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again. |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
…the digitization code
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-notrun
tests-rejected
labels
|
Pull request #19867 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again. |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
@civanch I put the masks in PCaloHit class whose member is having depth which is now presented with packed bit information. So the BuildFile's are not modified and dependency is unchanged. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
@davidlange6 @civanch The main idea of this PR is that one can go beyond the SIM step with information about the depth within crystal. The DIGI step used to assume that depth can be an integer between 0 and 2 (crystal and two areas of the APD's). Now with 0 and 14 bits to store depth within crystal one can go to the end (GEN-SIM-DIGI-RECO) to study depth dependence in energy measurement (this was required by the Higgs mass group and they presented this in one ECAL DPG meeting). With these changes one can in principle make production with or without radiation length information. by changing python parameter |
|
+1 |
Also try to use the information if it is a normal or reflected crystal in analysis