New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move layer1SecondStageLUT to uint vector #19875
Conversation
l1t::LUT does not support 32-bit wide data! Cannot change l1t::LUT since it has already been persisted in the DB.
A new Pull Request was created by @nsmith- (Nicholas Smith) for master. It involves the following packages: L1Trigger/L1TCalorimeter @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
l1t::LUT does not support 32-bit wide data!
Cannot change l1t::LUT since it has already been persisted in the DB.
At present, the CaloLayer1 emulator has no knowledge of this parameter, so it is unaffected.
@kkotov no backport needed since P5 install is custom, right?