Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move layer1SecondStageLUT to uint vector #19875

Merged
merged 1 commit into from Aug 9, 2017

Conversation

nsmith-
Copy link
Contributor

@nsmith- nsmith- commented Jul 24, 2017

l1t::LUT does not support 32-bit wide data!
Cannot change l1t::LUT since it has already been persisted in the DB.

At present, the CaloLayer1 emulator has no knowledge of this parameter, so it is unaffected.

@kkotov no backport needed since P5 install is custom, right?

l1t::LUT does not support 32-bit wide data!
Cannot change l1t::LUT since it has already been persisted in the DB.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nsmith- (Nicholas Smith) for master.

It involves the following packages:

L1Trigger/L1TCalorimeter
L1TriggerConfig/L1TConfigProducers

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko, @thomreis this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor

rekovic commented Aug 8, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22144/console Started: 2017/08/08 15:40

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19875/22144/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2646495
  • DQMHistoTests: Total failures: 201
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2646113
  • DQMHistoTests: Total skipped: 181
  • DQMHistoTests: Total Missing objects: 0
  • Checked 102 log files, 14 edm output root files, 25 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Aug 8, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e870f2b into cms-sw:master Aug 9, 2017
@nsmith- nsmith- deleted the layer1SecondStageLUT_pr93x branch September 19, 2017 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants