Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run2 sim16 Add scenarios for T1/T2/BCML2 for post LS2 scenario #19883

Merged
merged 3 commits into from Aug 21, 2017

Conversation

bsunanda
Copy link
Contributor

Add facilities for flux studies in T1/T2 region in PostLS1 and PostLS2 scenario
Avoid unwanted warnings from GEM geometry builder during initialization

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 24, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21712/console Started: 2017/07/24 17:44

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/CMSCommonData
Geometry/ForwardCommonData
Geometry/MuonCommonData
SimG4CMS/Forward

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @ptcox, @makortel this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

@bsunanda I'm about to submit a PR for the Run3 workflow that will conflict with this one. Can we put this one on hold until that one goes in? That way, this one can be tested with the full workflow.

@kpedro88
Copy link
Contributor

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @kpedro88
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Jul 24, 2017
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19883/21712/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 2355459
  • DQMHistoTests: Total failures: 15119
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2340174
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 93 log files, 14 edm output root files, 23 DQM output files

@bsunanda
Copy link
Contributor Author

@kpedro88 What is the status of the other PR. Could you please unhold this when appropriate

@kpedro88
Copy link
Contributor

@bsunanda waiting on a fix related to Phase1 pixel DQM, hopefully it will be resolved soon

@ianna
Copy link
Contributor

ianna commented Aug 3, 2017

@kpedro88 - any news?

@kpedro88
Copy link
Contributor

kpedro88 commented Aug 3, 2017

just waiting for one signature now...

@ianna
Copy link
Contributor

ianna commented Aug 4, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22205/console Started: 2017/08/10 22:08

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19883/22205/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2713569
  • DQMHistoTests: Total failures: 848
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2712532
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@bsunanda
Copy link
Contributor Author

@kpedro88 @ianna @civanch Please approve this

@ianna
Copy link
Contributor

ianna commented Aug 12, 2017

+1

@civanch
Copy link
Contributor

civanch commented Aug 14, 2017

+1

@kpedro88
Copy link
Contributor

@bsunanda should https://github.com/cms-sw/cmssw/blob/master/Geometry/CMSCommonData/python/cmsExtendedGeometry2019XML_cfi.py be updated to use the new XML files introduced in this PR, or will that be done in a subsequent PR?

@bsunanda
Copy link
Contributor Author

@kpedro88 It will be done in a subsequent PR. Please approve this

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants