New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run2 sim16 Add scenarios for T1/T2/BCML2 for post LS2 scenario #19883
Conversation
@cmsbuild Please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @bsunanda for master. It involves the following packages: Geometry/CMSCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@bsunanda I'm about to submit a PR for the Run3 workflow that will conflict with this one. Can we put this one on hold until that one goes in? That way, this one can be tested with the full workflow. |
hold |
Pull request has been put on hold by @kpedro88 |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@kpedro88 What is the status of the other PR. Could you please unhold this when appropriate |
@bsunanda waiting on a fix related to Phase1 pixel DQM, hopefully it will be resolved soon |
@kpedro88 - any news? |
just waiting for one signature now... |
+1 |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
@bsunanda should https://github.com/cms-sw/cmssw/blob/master/Geometry/CMSCommonData/python/cmsExtendedGeometry2019XML_cfi.py be updated to use the new XML files introduced in this PR, or will that be done in a subsequent PR? |
@kpedro88 It will be done in a subsequent PR. Please approve this |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Add facilities for flux studies in T1/T2 region in PostLS1 and PostLS2 scenario
Avoid unwanted warnings from GEM geometry builder during initialization