gcc7 compilation warning(s) fix(es) in RecoGamma & RecoMuon #19904

mrodozov · 2017-07-25T15:47:03Z

Fix for compilation warning(s) when compiling with gcc7 and more flags listed here:
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc700/CMSSW_9_3_X_2017-07-24-2300/RecoMuon/MuonIsolation
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc700/CMSSW_9_3_X_2017-07-24-2300/RecoEgamma/EgammaIsolationAlgos
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc700/CMSSW_9_3_X_2017-07-24-2300/RecoMuon/TrackingTools

cmsbuild · 2017-07-25T15:47:24Z

A new Pull Request was created by @mrodozov for master.

It involves the following packages:

RecoEgamma/EgammaIsolationAlgos
RecoMuon/MuonIsolation
RecoMuon/TrackingTools

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Sam-Harper, @battibass, @abbiendi, @jhgoh, @lgray, @echapon, @calderona, @HuguesBrun, @bellan, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

perrotta · 2017-07-25T21:56:25Z

RecoMuon/TrackingTools/src/MuonTrackLoader.cc

@@ -202,7 +202,7 @@ MuonTrackLoader::loadTracks(const TrajectoryContainer& trajectories,
  reco::TrackRef::key_type trackUpdatedIndex = 0;

  reco::TrackExtraRef::key_type trackExtraIndex = 0;
-  TrackingRecHitRef::key_type recHitsIndex = 0;
+  //TrackingRecHitRef::key_type recHitsIndex = 0;


Please remove this commented out code

perrotta · 2017-07-25T21:56:36Z

RecoMuon/TrackingTools/src/MuonTrackLoader.cc

@@ -544,7 +544,7 @@ MuonTrackLoader::loadTracks(const TrajectoryContainer& trajectories,
  //  reco::TrackRef::key_type trackUpdatedIndex = 0;


Please remove this commented out code

perrotta · 2017-07-25T21:56:45Z

RecoMuon/TrackingTools/src/MuonTrackLoader.cc

@@ -544,7 +544,7 @@ MuonTrackLoader::loadTracks(const TrajectoryContainer& trajectories,
  //  reco::TrackRef::key_type trackUpdatedIndex = 0;

  reco::TrackExtraRef::key_type trackExtraIndex = 0;
-  TrackingRecHitRef::key_type recHitsIndex = 0;
+  //TrackingRecHitRef::key_type recHitsIndex = 0;


Please remove this commented out code

davidlange6 · 2017-07-26T07:52:51Z

please test

cmsbuild · 2017-07-26T07:53:57Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21770/console Started: 2017/07/26 09:55

cmsbuild · 2017-07-26T09:07:38Z

+1
Tested at: 63cd35e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19904/21770/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
cc98e01
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19904/21770/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19904/21770/git-merge-result

cmsbuild · 2017-07-26T09:07:41Z

Comparison job queued.

cmsbuild · 2017-07-26T17:30:07Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19904/21770/summary.html

Comparison Summary:

You potentially added 5 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 2363781
DQMHistoTests: Total failures: 14613
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2349002
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 93 log files, 14 edm output root files, 23 DQM output files

perrotta · 2017-07-27T16:26:47Z

@mrodozov : do you plan to remove the commented out lines, as suggested in #19904 (review) ?

Otherwise please add some further comment in the code which explains why they are needed

cmsbuild · 2017-07-28T08:43:16Z

Pull request #19904 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

cmsbuild · 2017-07-28T08:46:11Z

Pull request #19904 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

cmsbuild · 2017-07-28T09:28:37Z

Pull request #19904 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

cmsbuild · 2017-07-28T10:09:04Z

Pull request #19904 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

cmsbuild · 2017-07-28T10:23:48Z

Pull request #19904 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

mrodozov · 2017-07-28T10:23:58Z

please test

cmsbuild · 2017-07-28T10:24:03Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21848/console Started: 2017/07/28 12:27

cmsbuild · 2017-07-28T11:17:47Z

+1
Tested at: f5e23fb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19904/21848/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
29a96fd
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19904/21848/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19904/21848/git-merge-result

cmsbuild · 2017-07-28T11:17:50Z

Comparison job queued.

cmsbuild · 2017-07-28T14:01:03Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19904/21848/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 2376534
DQMHistoTests: Total failures: 25280
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2351088
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 93 log files, 14 edm output root files, 23 DQM output files

perrotta · 2017-07-28T14:10:34Z

+1
Technical
No changes expected, no changes observed in tests
It does not involve recoEGamma any more

cmsbuild · 2017-07-28T14:10:51Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

davidlange6 · 2017-07-31T06:41:51Z

+1

cmsbuild added this to the CMSSW_9_3_X milestone Jul 25, 2017

cmsbuild added comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jul 25, 2017

perrotta reviewed Jul 25, 2017

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Jul 26, 2017

cmsbuild added tests-approved and removed tests-started labels Jul 26, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 26, 2017

mrodozov force-pushed the cmp-wngs-fix-reco-gamma-muon-gcc7 branch from 63cd35e to 8bb1ce2 Compare July 28, 2017 08:42

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Jul 28, 2017

mrodozov force-pushed the cmp-wngs-fix-reco-gamma-muon-gcc7 branch from f9aad1e to e28e15d Compare July 28, 2017 10:08

gcc7 compilation warnings fix in RecoJets pkgs

f5e23fb

mrodozov force-pushed the cmp-wngs-fix-reco-gamma-muon-gcc7 branch from e28e15d to f5e23fb Compare July 28, 2017 10:23

cmsbuild added tests-started and removed tests-pending labels Jul 28, 2017

cmsbuild added tests-approved and removed tests-started labels Jul 28, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 28, 2017

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Jul 28, 2017

cmsbuild added orp-approved and removed orp-pending labels Jul 31, 2017

cmsbuild merged commit 54ceb98 into cms-sw:master Jul 31, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gcc7 compilation warning(s) fix(es) in RecoGamma & RecoMuon #19904

gcc7 compilation warning(s) fix(es) in RecoGamma & RecoMuon #19904

mrodozov commented Jul 25, 2017

cmsbuild commented Jul 25, 2017

perrotta Jul 25, 2017

perrotta Jul 25, 2017

perrotta Jul 25, 2017

davidlange6 commented Jul 26, 2017

cmsbuild commented Jul 26, 2017 •

edited

cmsbuild commented Jul 26, 2017

cmsbuild commented Jul 26, 2017

cmsbuild commented Jul 26, 2017

perrotta commented Jul 27, 2017

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

mrodozov commented Jul 28, 2017

cmsbuild commented Jul 28, 2017 •

edited

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

perrotta commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

davidlange6 commented Jul 31, 2017

		@@ -544,7 +544,7 @@ MuonTrackLoader::loadTracks(const TrajectoryContainer& trajectories,
		// reco::TrackRef::key_type trackUpdatedIndex = 0;

gcc7 compilation warning(s) fix(es) in RecoGamma & RecoMuon #19904

gcc7 compilation warning(s) fix(es) in RecoGamma & RecoMuon #19904

Conversation

mrodozov commented Jul 25, 2017

cmsbuild commented Jul 25, 2017

perrotta Jul 25, 2017

Choose a reason for hiding this comment

perrotta Jul 25, 2017

Choose a reason for hiding this comment

perrotta Jul 25, 2017

Choose a reason for hiding this comment

davidlange6 commented Jul 26, 2017

cmsbuild commented Jul 26, 2017 • edited

cmsbuild commented Jul 26, 2017

cmsbuild commented Jul 26, 2017

cmsbuild commented Jul 26, 2017

perrotta commented Jul 27, 2017

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

mrodozov commented Jul 28, 2017

cmsbuild commented Jul 28, 2017 • edited

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

perrotta commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

davidlange6 commented Jul 31, 2017

cmsbuild commented Jul 26, 2017 •

edited

cmsbuild commented Jul 28, 2017 •

edited