-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcc7 compilation warning(s) fix(es) in RecoGamma & RecoMuon #19904
gcc7 compilation warning(s) fix(es) in RecoGamma & RecoMuon #19904
Conversation
A new Pull Request was created by @mrodozov for master. It involves the following packages: RecoEgamma/EgammaIsolationAlgos @perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@@ -202,7 +202,7 @@ MuonTrackLoader::loadTracks(const TrajectoryContainer& trajectories, | |||
reco::TrackRef::key_type trackUpdatedIndex = 0; | |||
|
|||
reco::TrackExtraRef::key_type trackExtraIndex = 0; | |||
TrackingRecHitRef::key_type recHitsIndex = 0; | |||
//TrackingRecHitRef::key_type recHitsIndex = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this commented out code
@@ -544,7 +544,7 @@ MuonTrackLoader::loadTracks(const TrajectoryContainer& trajectories, | |||
// reco::TrackRef::key_type trackUpdatedIndex = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this commented out code
@@ -544,7 +544,7 @@ MuonTrackLoader::loadTracks(const TrajectoryContainer& trajectories, | |||
// reco::TrackRef::key_type trackUpdatedIndex = 0; | |||
|
|||
reco::TrackExtraRef::key_type trackExtraIndex = 0; | |||
TrackingRecHitRef::key_type recHitsIndex = 0; | |||
//TrackingRecHitRef::key_type recHitsIndex = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this commented out code
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@mrodozov : do you plan to remove the commented out lines, as suggested in #19904 (review) ? Otherwise please add some further comment in the code which explains why they are needed |
63cd35e
to
8bb1ce2
Compare
Pull request #19904 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again. |
2 similar comments
Pull request #19904 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again. |
Pull request #19904 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again. |
f9aad1e
to
e28e15d
Compare
Pull request #19904 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again. |
e28e15d
to
f5e23fb
Compare
Pull request #19904 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
Fix for compilation warning(s) when compiling with gcc7 and more flags listed here:
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc700/CMSSW_9_3_X_2017-07-24-2300/RecoMuon/MuonIsolation
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc700/CMSSW_9_3_X_2017-07-24-2300/RecoEgamma/EgammaIsolationAlgos
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc700/CMSSW_9_3_X_2017-07-24-2300/RecoMuon/TrackingTools