Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare several classes as non-storable #1991

Conversation

Dr15Jones
Copy link
Contributor

Several of the classes which are only used for interactive use
can not be stored since they will cause ROOT to crash if one requests
their StreamerInfo. This change just marks those classes as non persistent.
This change is needed for the threaded framework to know not to request
the construction of the StreamInfo for those classes.

Several of the classes which are only used for interactive use
can not be stored since they will cause ROOT to crash if one requests
their StreamerInfo. This change just marks those classes as non persistent.
This change is needed for the threaded framework to know not to request
the construction of the StreamInfo for those classes.
@Dr15Jones
Copy link
Contributor Author

@ktf One more change needed by THREADED_X but still a bug so should go into 7_0_X. Attempts to write such objects would crash ROOT so there should be no adverse affects from this change.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X.

Declare several classes as non-storable

It involves the following packages:

RecoParticleFlow/PFRootEvent

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@Dr15Jones
Copy link
Contributor Author

@ktf please override the signatures as long as the Jenkin's test pass. I need this and #1989 in before I make a pull request for _THREADED_X which loads all StreamerInfos else all RelVals for the _THREADED_X will crash.

@slava77
Copy link
Contributor

slava77 commented Jan 13, 2014

ok to override from my side, assuming jenkins ok

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@Dr15Jones
Copy link
Contributor Author

@ktf please merge this.. Slava already said it is fine to override.

ktf added a commit that referenced this pull request Jan 14, 2014
…oParticleFlowPFRootEvent

Reco fixes -- Declare several classes as non-storable
@ktf ktf merged commit d002fbc into cms-sw:CMSSW_7_0_X Jan 14, 2014
@Dr15Jones Dr15Jones deleted the makeClassesNonPersistentInRecoParticleFlowPFRootEvent branch January 17, 2014 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants