Run2-hcx139 Update geometry access for Hcal cells

[bsunanda]

In view of collapsed depths in Plan 1 reconstruction

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21751/console Started: 2017/07/25 21:44

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

RecoMET/METAlgorithms

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @ahinzmann, @mmarionncern, @jdolen, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21752/console Started: 2017/07/25 21:54

[cmsbuild]

+1
Tested at: 1bb9470
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19910/21752/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
939e204
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19910/21752/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19910/21752/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19910/21752/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 2363781
• DQMHistoTests: Total failures: 15034
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2348581
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 93 log files, 14 edm output root files, 23 DQM output files

[bsunanda]

These two plots of efficiency demonstrate that the modified code improve the efficiency (the earlier version gives much lower efficiency particularly for the tight version)

[slava77]

On 7/26/17 7:47 AM, bsunanda wrote: These two plots of efficiency demonstrate that the modified code improve the efficiency (the earlier version gives much lower efficiency particularly for the tight version)

please post plots for efficiency before the change to actually be able to compare. Thank you.

[dvannerom]

Dear Slava,

Here are the same plots but with the bugged version of the code. You can see the very low efficiency of the tight version, while the supertight is ok.

eff_globalsupertighthalo2016_bug.pdf
eff_globaltighthalo2016_bug.pdf

Cheers,
David

[slava77]

IIUC, there is no DQM for these quantities.
Why not?

I will add GlobalTightHaloId2016 and GlobalSuperTightHaloId2016 to reco fwlite-based monitoring

[mariadalfonso]

@slava77
If I recall correctly these (or an older version of these) were part of the METfilters DQM suites

In this specific case some of the HEP17 merged hits, w/o this fix get assigned and unphysical position at eta,phi=0,0

[slava77]

On 7/27/17 1:49 PM, mariadalfonso wrote: @slava77 <https://github.com/slava77> If I recall correctly these (or an older version of these) were part of the METfilters DQM suites

I ran on 2017B workflows from the matrix 136.781,136.782,136.783,136.784,136.788 200 events each and none of them showed any differences. My fwlite based plots clearly show there is a change in these workflows in BeamHaloSummary.GlobalTightHaloId2016 So, my conclusion is it is not in DQM

…

In this specific case some of the HEP17 merged hits, w/o this fix get assigned and unphysical position at eta,phi=0,0 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19910 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdcblgpOJtQ6Q3jpaejDiJ_umEU86H1ks5sSPfrgaJpZM4OjCKI>.

[slava77]

+1

for #19910 1bb9470

• HcalHaloAlgo::getPosition(const DetId &id now uses HcalGeometry to get the cell position, instead of CaloGeometry directly, which apparently doesn't return the right value for HEP17
• jenkins tests pass and comparisons show no differences (monitoring is apparently lacking)
• local test with 2017 data workflows and added monitoring of the halo id variable shows expected behavior with much smaller tag rate; e.g. in 136.783
  

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[mariadalfonso]

@slava77
These are the list of METfilters in DQM and indeed the latest version of the Halo is not up to date

cmssw/DQMOffline/JetMET/python/metDQMConfig_cfi.py

Lines 108 to 116 in 09c3fce

	HcalNoiseRBXCollection = cms.InputTag("hcalnoise"),
	HBHENoiseFilterResultLabel = cms.InputTag("HBHENoiseFilterResultProducer", "HBHENoiseFilterResult"),
	HBHENoiseIsoFilterResultLabel = cms.InputTag("HBHENoiseFilterResultProducer", "HBHEIsoNoiseFilterResult"),
	CSCHaloResultLabel = cms.InputTag("CSCTightHaloFilterDQM"),
	CSCHalo2015ResultLabel = cms.InputTag("CSCTightHalo2015FilterDQM"),
	EcalDeadCellTriggerPrimitiveFilterLabel = cms.InputTag("EcalDeadCellTriggerPrimitiveFilterDQM"),
	EcalDeadCellBoundaryEnergyFilterLabel = cms.InputTag("EcalDeadCellBoundaryEnergyFilterDQM"),
	eeBadScFilterLabel = cms.InputTag("eeBadScFilterDQM"),
	HcalStripHaloFilterLabel = cms.InputTag("HcalStripHaloFilterDQM"),

@ramankhurana will take care of updating in a separate PR.

[davidlange6]

+1