Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add collections for EXONoBPTXSkim (93X) #19953

Merged
merged 1 commit into from Jul 30, 2017

Conversation

jalimena
Copy link
Contributor

Add additional collections needed to redo muon timing, which is essential for EXO-17-004, which relies on this skim.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jalimena (Juliette Alimena) for master.

It involves the following packages:

Configuration/Skimming

@cmsbuild, @kkousour, @davidlange6, @GurpreetSinghChahal, @fabozzi can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@fabozzi
Copy link
Contributor

fabozzi commented Jul 28, 2017

please test 136.791

@fabozzi
Copy link
Contributor

fabozzi commented Jul 28, 2017

@kfjack

@fabozzi
Copy link
Contributor

fabozzi commented Jul 28, 2017

please test workflow 136.791

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 28, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21873/console Started: 2017/07/28 17:35

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19953/21873/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1386 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 2376234
  • DQMHistoTests: Total failures: 67188
  • DQMHistoTests: Total nulls: 301
  • DQMHistoTests: Total successes: 2308579
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 93 log files, 14 edm output root files, 23 DQM output files

@fabozzi
Copy link
Contributor

fabozzi commented Jul 30, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 8571add into cms-sw:master Jul 30, 2017
@jalimena jalimena deleted the ExoNoBptxSkimFix93X branch November 11, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants