uGMT fixes for intermediate muons - 93x #19956

thomreis · 2017-07-28T14:54:28Z

Two fixes for the uGMT intermediate muons used by the DQM.

Add missing link to the unpacker to get all intermediates from EMTF-.
Set the isolation variable of the emulator to the same value as the unpacker (0).

cmsbuild · 2017-07-28T14:54:59Z

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

EventFilter/L1TRawToDigi
L1Trigger/L1TMuon

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

rekovic · 2017-07-28T15:48:15Z

please test

cmsbuild · 2017-07-28T15:48:33Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21876/console Started: 2017/07/28 17:51

cmsbuild · 2017-07-28T17:10:32Z

+1
Tested at: abbac12
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19956/21876/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
29a96fd
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19956/21876/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19956/21876/git-merge-result

cmsbuild · 2017-07-28T17:10:34Z

Comparison job queued.

rekovic · 2017-07-28T18:26:41Z

+1

cmsbuild · 2017-07-28T18:26:56Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

cmsbuild · 2017-07-28T21:27:52Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19956/21876/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 2376534
DQMHistoTests: Total failures: 40138
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2336230
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 93 log files, 14 edm output root files, 23 DQM output files

davidlange6 · 2017-07-31T08:11:35Z

EventFilter/L1TRawToDigi/plugins/implementations_stage2/GMTSetup.cc

@@ -85,7 +85,7 @@ namespace l1t {
         // internal muons
         auto gmt_imd_unp = static_pointer_cast<l1t::stage2::IntermediateMuonUnpacker>(UnpackerFactory::get()->make("stage2::IntermediateMuonUnpacker"));
         gmt_imd_unp->setAlgoVersion(fw);
-         for (int oLink = 49; oLink < 63; oLink += 2)
+         for (int oLink = 49; oLink < 65; oLink += 2)


hi @thomreis @rekovic - please document these magic numbers with a comment. Thanks

@davidlange6 I have added some comments explaining the numbers.

cmsbuild · 2017-08-01T07:11:47Z

Pull request #19956 was updated. @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again.

rekovic · 2017-08-01T09:40:59Z

please test

rekovic · 2017-08-01T09:41:04Z

+1

cmsbuild · 2017-08-01T09:41:15Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21950/console Started: 2017/08/01 11:41

cmsbuild · 2017-08-01T09:41:16Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

rekovic · 2017-08-01T10:02:22Z

@thomreis
Please add the same last commit to the 92x pr #19958

thomreis · 2017-08-01T10:05:07Z

@rekovic it is already there. Different hash because it was cherry-picked for the 92x PR.

cmsbuild · 2017-08-01T11:16:05Z

+1
Tested at: 6467e7e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19956/21950/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
46f824c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19956/21950/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19956/21950/git-merge-result

cmsbuild · 2017-08-01T11:16:07Z

Comparison job queued.

cmsbuild · 2017-08-01T16:17:32Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19956/21950/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 25
DQMHistoTests: Total histograms compared: 2651091
DQMHistoTests: Total failures: 75649
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2575261
DQMHistoTests: Total skipped: 181
DQMHistoTests: Total Missing objects: 0
Checked 102 log files, 14 edm output root files, 25 DQM output files

davidlange6 · 2017-08-02T08:11:00Z

+1

thomreis added 2 commits July 28, 2017 16:40

Set iso for intermediate muons like it is set in the FW (0).

a976aaa

Set correct number of intermediate muon links to readout.

abbac12

cmsbuild added this to the CMSSW_9_3_X milestone Jul 28, 2017

cmsbuild added comparison-pending l1-pending orp-pending pending-signatures tests-pending labels Jul 28, 2017

This was referenced Jul 28, 2017

uGMT fixes for intermediate muons - 92x #19958

Merged

uGMT intermediate muon upgrades for DQM cms-l1t-offline/cmssw#593

Merged

cmsbuild added tests-started and removed tests-pending labels Jul 28, 2017

cmsbuild added tests-approved and removed tests-started labels Jul 28, 2017

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Jul 28, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 28, 2017

davidlange6 reviewed Jul 31, 2017

View reviewed changes

Documenting MP7 link numbers in unpacker setup.

6467e7e

cmsbuild added comparison-pending l1-pending pending-signatures tests-pending and removed tests-approved labels Aug 1, 2017

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Aug 1, 2017

cmsbuild added tests-started and removed tests-pending labels Aug 1, 2017

cmsbuild added tests-approved and removed tests-started labels Aug 1, 2017

cmsbuild added comparison-available and removed comparison-pending labels Aug 1, 2017

cmsbuild added orp-approved and removed orp-pending labels Aug 2, 2017

cmsbuild merged commit f7aeaa9 into cms-sw:master Aug 2, 2017

thomreis deleted the uGMT_fixes_for_dqm_93x branch August 4, 2017 15:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

uGMT fixes for intermediate muons - 93x #19956

uGMT fixes for intermediate muons - 93x #19956

thomreis commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

rekovic commented Jul 28, 2017

cmsbuild commented Jul 28, 2017 •

edited

Loading

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

rekovic commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

davidlange6 Jul 31, 2017

thomreis Aug 1, 2017

cmsbuild commented Aug 1, 2017

rekovic commented Aug 1, 2017

rekovic commented Aug 1, 2017

cmsbuild commented Aug 1, 2017 •

edited

Loading

cmsbuild commented Aug 1, 2017

rekovic commented Aug 1, 2017

thomreis commented Aug 1, 2017

cmsbuild commented Aug 1, 2017

cmsbuild commented Aug 1, 2017

cmsbuild commented Aug 1, 2017

davidlange6 commented Aug 2, 2017

uGMT fixes for intermediate muons - 93x #19956

uGMT fixes for intermediate muons - 93x #19956

Conversation

thomreis commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

rekovic commented Jul 28, 2017

cmsbuild commented Jul 28, 2017 • edited Loading

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

rekovic commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

davidlange6 Jul 31, 2017

Choose a reason for hiding this comment

thomreis Aug 1, 2017

Choose a reason for hiding this comment

cmsbuild commented Aug 1, 2017

rekovic commented Aug 1, 2017

rekovic commented Aug 1, 2017

cmsbuild commented Aug 1, 2017 • edited Loading

cmsbuild commented Aug 1, 2017

rekovic commented Aug 1, 2017

thomreis commented Aug 1, 2017

cmsbuild commented Aug 1, 2017

cmsbuild commented Aug 1, 2017

cmsbuild commented Aug 1, 2017

davidlange6 commented Aug 2, 2017

cmsbuild commented Jul 28, 2017 •

edited

Loading

cmsbuild commented Aug 1, 2017 •

edited

Loading