Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uGMT fixes for intermediate muons - 92x #19958

Merged
merged 3 commits into from Aug 11, 2017

Conversation

thomreis
Copy link
Contributor

Two fixes for the uGMT intermediate muons used by the DQM.

  • Add missing link to the unpacker to get all intermediates from EMTF-.
  • Set the isolation variable of the emulator to the same value as the unpacker (0).

@thomreis
Copy link
Contributor Author

backport of #19956

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 28, 2017

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_9_2_X.

It involves the following packages:

EventFilter/L1TRawToDigi
L1Trigger/L1TMuon

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor Author

This should fix the failing quality tests for uGMT data vs. emulator comparison in the online DQM.

@rekovic
Copy link
Contributor

rekovic commented Jul 28, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 28, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21877/console Started: 2017/07/28 17:51

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@rekovic
Copy link
Contributor

rekovic commented Jul 28, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19958/21877/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1791747
  • DQMHistoTests: Total failures: 29846
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1761735
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

Pull request #19958 was updated. @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again.

@rekovic
Copy link
Contributor

rekovic commented Aug 4, 2017

please test

@rekovic
Copy link
Contributor

rekovic commented Aug 4, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22085/console Started: 2017/08/04 11:31

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19958/22085/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1791842
  • DQMHistoTests: Total failures: 29838
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1761838
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7130621 into cms-sw:CMSSW_9_2_X Aug 11, 2017
@thomreis thomreis deleted the uGMT_fixes_for_dqm_92x branch August 30, 2017 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants