Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stack size control #1996

Merged
merged 2 commits into from Jan 13, 2014
Merged

Add stack size control #1996

merged 2 commits into from Jan 13, 2014

Conversation

Dr15Jones
Copy link
Contributor

Although this change is primarily for THREADED_X build, we've previously put all similar changes int the non-threaded build as well. This keeps the cmsRun command line arguments and process.options parameters between the two builds the same.

@Dr15Jones
Add option to set stack size for threads
987cbc0 
Added the ability to tell TBB what stack size to use for new threads.
This is can be done either at the command line or via the process.options
parameter of the configuration. If no value is given, it defaults to the
system default size. This has no effect on the main thread or a single
threaded program.
@Dr15Jones
Set stack size for additional threads to 10MB
945045a 
The IB RelVal 10.0 needs 10MB for stack size in order to read the
extremely large graph of edm::HepMCProduct stored in the ROOT file.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X.

Add stack size control

It involves the following packages:

FWCore/Concurrency
FWCore/Framework

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1996/1995/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes (tests are also fine). @ktf can you please take care of it?

ktf added a commit that referenced this pull request Jan 13, 2014
@ktf
Merge pull request #1996 from Dr15Jones/addStackSizeControl
f0b3ca2 
Multithreading fixes -- Add stack size control
@ktf ktf merged commit f0b3ca2 into cms-sw:CMSSW_7_0_X Jan 13, 2014
@Dr15Jones Dr15Jones deleted the addStackSizeControl branch January 17, 2014 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_0_0_pre12
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dr15Jones @cmsbuild @ktf