New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old FileInPath #19983
Remove old FileInPath #19983
Conversation
Removed include of old Utilities/General/interface/FileInPath.h
Replaced the incorrect include from Utilities/General with the correct one from FWCore/ParameterSet.
The use of ::FileInPath is deprecated. Using edm::FileInPath can achieve the same results.
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: GeneratorInterface/EvtGenInterface @efeyazgan, @perrozzi, @civanch, @mdhildreth, @cmsbuild, @thuer, @govoni, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
The class ::FileInPath in Utilities/General is a left-over from the transition to CMSSW. We are working towards removing it. All known uses of ::FileInPath can be replaced with edm::FileInPath which hides
which exact environment variables CMSSW uses to find data files.