Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old FileInPath #19983

Merged
merged 3 commits into from Aug 1, 2017
Merged

Remove old FileInPath #19983

merged 3 commits into from Aug 1, 2017

Conversation

Dr15Jones
Copy link
Contributor

The class ::FileInPath in Utilities/General is a left-over from the transition to CMSSW. We are working towards removing it. All known uses of ::FileInPath can be replaced with edm::FileInPath which hides
which exact environment variables CMSSW uses to find data files.

Removed include of old Utilities/General/interface/FileInPath.h
Replaced the incorrect include from Utilities/General with the
correct one from FWCore/ParameterSet.
The use of ::FileInPath is deprecated. Using edm::FileInPath can
achieve the same results.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

GeneratorInterface/EvtGenInterface
SimMuon/CSCDigitizer

@efeyazgan, @perrozzi, @civanch, @mdhildreth, @cmsbuild, @thuer, @govoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ptcox, @alberto-sanchez, @agrohsje, @mkirsano, @jhgoh this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 31, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21928/console Started: 2017/07/31 20:46

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19983/21928/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2651091
  • DQMHistoTests: Total failures: 60860
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2590050
  • DQMHistoTests: Total skipped: 181
  • DQMHistoTests: Total Missing objects: 0
  • Checked 102 log files, 14 edm output root files, 25 DQM output files

@perrozzi
Copy link
Contributor

perrozzi commented Aug 1, 2017

+1

@civanch
Copy link
Contributor

civanch commented Aug 1, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ff15bd6 into cms-sw:master Aug 1, 2017
@Dr15Jones Dr15Jones deleted the removeOldFileInPath branch August 1, 2017 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants