Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created LimitedTaskQueue #19985

Merged
merged 2 commits into from Aug 1, 2017
Merged

Created LimitedTaskQueue #19985

merged 2 commits into from Aug 1, 2017

Conversation

Dr15Jones
Copy link
Contributor

A LimitedTaskQueue can be used to protect a thread-safe resource where the resource needs to limit the number of threads that access it simultaneously.

Added the class and its unit test
Running the test in the debugger showed that creating extra threads and calling task::spawn on them was sometimes causing seg faults in a related test.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Concurrency

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

@dan131riley here is what I plan to use as the internals of the ::limited module type

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 31, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21935/console Started: 2017/08/01 02:21

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19985/21935/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2651091
  • DQMHistoTests: Total failures: 61186
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2589724
  • DQMHistoTests: Total skipped: 181
  • DQMHistoTests: Total Missing objects: 0
  • Checked 102 log files, 14 edm output root files, 25 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 31281ca into cms-sw:master Aug 1, 2017
@Dr15Jones Dr15Jones deleted the limitedQueue branch August 1, 2017 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants