Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug fix in hltGetConfiguration - 93X #20004

Merged
merged 1 commit into from Aug 2, 2017

Conversation

silviodonato
Copy link
Contributor

This PR solve the following bug related to '--setup' option:
hltGetConfiguration /users/gennai/PFMET_MHT_Cleaned/V6 --full --offline --data --process MYHLT --globaltag 92X_upgrade2017_realistic_v7 --no-output --max-events -1 --setup /dev/CMSSW_9_2_0/GRun --input /store/relval/CMSSW_9_2_7/RelValTTbar_13/GEN-SIM-DIGI-RAW/PU25ns_92X_upgrade2017_realistic_v7-v1/00000/028A4997-C570-E711-8116-0CC47A7AB7A0.root --l1-emulator uGT --l1 L1Menu_Collisions2017_v2_m6_full_xml > hlt.py &

It give the error

----- Begin Fatal Exception 01-Aug-2017 15:43:52 CEST-----------------------
An exception of category 'PrescaleServiceConfigError' occurred while
   [0] Calling beginJob
Exception Message:
 Path 'AlCa_EcalPhiSym_v8' is unknown or does not contain any HLTPrescaler!
----- End Fatal Exception ------------------------------------------------- 

This has been fixed removing all PSets in PrescaleService pointing to missing HLT paths.

This PR removes also a customization part that is obsolete since we are using '@currentProcess' in HLT menu (see CMSHLT-1466)

PR 93X: #20003

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @geoff-smith, @jalimena this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

The tests are being triggered in jenkins.

@Martin-Grunewald
Copy link
Contributor

@silviodonato
We could probably also get rid of these lines, then:
https://github.com/cms-sw/cmssw/blob/master/HLTrigger/Configuration/python/CustomConfigs.py#L11-L18
(though not the complete function as it is called from elsewhere)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20004/21980/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2651091
  • DQMHistoTests: Total failures: 60993
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2589917
  • DQMHistoTests: Total skipped: 181
  • DQMHistoTests: Total Missing objects: 0
  • Checked 102 log files, 14 edm output root files, 25 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

Pull request #20004 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again.

1 similar comment
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

Pull request #20004 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again.

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22000/console Started: 2017/08/02 10:45

@Martin-Grunewald
Copy link
Contributor

please abort

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

Jenkins tests are aborted.

@Martin-Grunewald
Copy link
Contributor

-1
later changes from #20003 should be added here as well

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22006/console Started: 2017/08/02 11:18

@silviodonato
Copy link
Contributor Author

now it's synchronized with #20003

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

Comparison job queued.

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 702105c into cms-sw:master Aug 2, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20004/22006/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2651091
  • DQMHistoTests: Total failures: 46413
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2604497
  • DQMHistoTests: Total skipped: 181
  • DQMHistoTests: Total Missing objects: 0
  • Checked 102 log files, 14 edm output root files, 25 DQM output files

@Martin-Grunewald Martin-Grunewald deleted the hltGetConfiguration_fix_93X branch September 7, 2017 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants