Wait in destructor of SerialTaskQueue #20009
Conversation
Do a 'pushAndWait' in the destructor of the SerialTaskQueue if there are outstanding tasks being processed. This avoids a possible crash caused if the task tries to talk back to the deleted SerialTaskQueue. This problem was pointed out by valgrind.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Concurrency @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@smuzaffar @davidlange6 this bug was probably the cause of the unit test crash. |
|
please test |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
type bug |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
merge |
|
Comparison is ready Comparison Summary:
|
Do a 'pushAndWait' in the destructor of the SerialTaskQueue if there are outstanding tasks being processed. This avoids a possible crash caused if the task tries to talk back to the deleted SerialTaskQueue.
This problem was pointed out by valgrind.