Memory reduction of the Cluster Charge Histogram used in SiStrip gain calibration (92X)

[dimattia]

This pull requests implements the code needed to reduce the number of bins of the cluster charge histogram. It is the backport on 92X of #20010

[cmsbuild]

A new Pull Request was created by @dimattia for CMSSW_9_2_X.

It involves the following packages:

CalibTracker/SiStripChannelGain
DQMServices/Core

@ghellwig, @vazzolini, @kmaeshima, @arunhep, @cerminar, @dmitrijus, @cmsbuild, @franzoni, @vanbesien, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @barvic, @gbenelli, @tocheng, @jlagram, @OlivierBondu, @mmusich this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

• Backported from Memory reduction of the Cluster Charge Histogram used in SiStrip gain calibration #20010

[arunhep]

backport of #20010

[arunhep]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21991/console Started: 2017/08/02 01:16

[arunhep]

@dimattia please change the title of this PR to make it more clear.

[mmusich]

Hi @dimattia,
for the sake of documentation, can you change the PR title to something more descriptive than "first implementation"?

[cmsbuild]

+1
Tested at: dd4ac9d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20011/21991/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
79d69df
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20011/21991/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20011/21991/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20011/21991/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 22
• DQMHistoTests: Total histograms compared: 1791780
• DQMHistoTests: Total failures: 15026
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 1776587
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 90 log files, 14 edm output root files, 22 DQM output files

[arunhep]

+1

[franzoni]

@dmitrijus would it be possible for you to take a look at this, and give feedback ?
thanks !

[cmsbuild]

Pull request #20011 was updated. @ghellwig, @vazzolini, @kmaeshima, @arunhep, @cerminar, @dmitrijus, @cmsbuild, @franzoni, @vanbesien, @lpernie can you please check and sign again.

[dmitrijus]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22855/console Started: 2017/09/11 15:53

[cmsbuild]

+1
Tested at: c8ef8e2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20011/22855/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
7c7cf4a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20011/22855/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20011/22855/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20011/22855/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1904607
• DQMHistoTests: Total failures: 29860
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 1874572
• DQMHistoTests: Total skipped: 174
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[lpernie]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1

[mmusich]

Hi @davidlange6, the original PR for the master branch (#20010) is still open. Was the merging of the backport intentional?

[davidlange6]

nope - i thought i had merged it already. now back in sync..