Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc7 compilation warning fix in RecoMuon/MuonIsolation package #20022

Merged

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Aug 2, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

A new Pull Request was created by @mrodozov for master.

It involves the following packages:

RecoMuon/MuonIsolation

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@bellan, @abbiendi, @jhgoh, @echapon, @calderona, @HuguesBrun, @battibass, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

mrodozov commented Aug 2, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22017/console Started: 2017/08/02 16:41

@mrodozov
Copy link
Contributor Author

mrodozov commented Aug 2, 2017

abort test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

Jenkins tests are aborted.

@mrodozov mrodozov force-pushed the cmp-wngs-fix-gcc7-RecoMuon/MuonIsolation branch from 1c9b41a to f7d6808 Compare August 2, 2017 15:38
@mrodozov
Copy link
Contributor Author

mrodozov commented Aug 2, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22022/console Started: 2017/08/02 18:38

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

Pull request #20022 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20022/22022/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2651091
  • DQMHistoTests: Total failures: 31639
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2619271
  • DQMHistoTests: Total skipped: 181
  • DQMHistoTests: Total Missing objects: 0
  • Checked 102 log files, 14 edm output root files, 25 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Aug 3, 2017

+1

  • Technical
  • No differences expected in jenkins tests, no differences observed

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bde6c50 into cms-sw:master Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants