New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcc7 compilation warning fix in EventFilter/CSCTFRawToDigi #20023
gcc7 compilation warning fix in EventFilter/CSCTFRawToDigi #20023
Conversation
A new Pull Request was created by @mrodozov for master. It involves the following packages: EventFilter/CSCTFRawToDigi @cmsbuild, @rekovic, @mulhearn can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: e6e1d57 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step4_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@@ -3,7 +3,7 @@ | |||
#include <string.h> | |||
#include <stdexcept> | |||
|
|||
unsigned int CSCTFEvent::unpack(const unsigned short *buf, unsigned int length) throw() { | |||
unsigned int CSCTFEvent::unpack(const unsigned short *buf, unsigned int length) noexcept(false) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @mrodozov - its probably best just to remove the throw() and replace it with nothing
@Dr15Jones (opinions?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, I've used the noexcept for destructors before that, seems I used it here 'by habit' instead of just remove the throw specifier. But since I think to overwrite the old commit, would you like me to wait for Chris to respond first or not ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no concerns with removing it.
e6e1d57
to
fa10223
Compare
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
merge |
Fining compiler warning listed here
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc700/CMSSW_9_3_X_2017-07-31-1200/EventFilter/CSCTFRawToDigi