DetectorDescription Clang Check modernize-use-emplace #20030
Conversation
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: DataFormats/Math @perrotta, @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
-1 Tested at: d91db70 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build ClangBuild
I found an error when building: >> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-02-2300/src/RecoMuon/Navigation/src/MuonEtaRange.cc
>> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-02-2300/src/RecoMuon/Navigation/src/MuonNavigableLayer.cc
>> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-02-2300/src/RecoMuon/Navigation/src/DirectMuonNavigation.cc
>> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-02-2300/src/Utilities/General/src/ClassName.cc
>> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-02-2300/src/Utilities/General/src/FileInPath.cc
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-02-2300/src/Utilities/General/src/FileInPath.cc:2:38: fatal error: boost/algorithm/string.hpp: No such file or directory
#include
^
compilation terminated.
gmake: *** [tmp/slc6_amd64_gcc630/src/Utilities/General/src/UtilitiesGeneral/FileInPath.o] Error 1
Entering library rule at RecoMuon/TrackingTools
I found a compilation error while trying to compile with clang: >> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-02-2300/src/Utilities/General/src/ClassName.cc
>> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-02-2300/src/Utilities/General/src/FileInPath.cc
>> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-02-2300/src/Utilities/General/test/TestTBB.cc
>> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-02-2300/src/Utilities/General/test/test_precomputed_value_sort.cpp
Entering library rule at src/DataFormats/Math/test
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-02-2300/src/Utilities/General/src/FileInPath.cc:2:10: fatal error: 'boost/algorithm/string.hpp' file not found
#include
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
>> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-02-2300/src/RecoVertex/KinematicFitPrimitives/src/KinematicParameters.cc
>> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-02-2300/src/RecoVertex/KinematicFitPrimitives/src/MultipleKinematicConstraint.cc
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
@smuzaffar - is there a problem with CLANG IB? |
ianna
changed the title
|
please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-notrun
tests-rejected
labels
|
The tests are being triggered in jenkins. |
|
The tests are being triggered in jenkins. |
|
abort |
|
Jenkins tests are aborted. |
|
test with #20033 |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
+1 |
|
@ianna : your PRs #20020 and #20030 interfere each other. Since they act on the same files they will not be mergeable any more as soon as one of the two gets merged first, (Checked just now on CMSSW_9_3_X_2017-08-03-140) Why not combine yourself those two (and possibly also #19978) into a single PR, that can be merged all at once? |
|
Comparison is ready Comparison Summary:
|
|
@perrotta - smaller PRs tend to be faster to integrate, even with if there are merging conflict fixes. |
|
On 8/3/17 10:06 AM, Ianna Osborne wrote:
@perrotta <https://github.com/perrotta> - smaller PRs tend to be faster
to integrate, even with if there are merging conflict fixes.
not when they edit the same files.
please factor out the DataFormats/Math, which is the only reco category
file into one PR.
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20030 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbmVmUTN4XWD5Rrtgllyh3CIfheMyks5sUf4pgaJpZM4OsGmP>.
|
|
@slava77 - ok, I'll merge all of the PRs in one. |
Replaces #19976 after merge of #19974