Run2-alca88 Modify macro used for IsoTrack calibration and add a test program for calibration of laser events

[bsunanda]

Thresholds for tuning HLT for Laser events in HCAL are determined from the test program

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22066/console Started: 2017/08/03 18:18

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Calibration/HcalCalibAlgos

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: ecb889b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20048/22066/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
cf6d2ab
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20048/22066/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20048/22066/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20048/22066/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 25
• DQMHistoTests: Total histograms compared: 2643105
• DQMHistoTests: Total failures: 15042
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2627882
• DQMHistoTests: Total skipped: 181
• DQMHistoTests: Total Missing objects: 0
• Checked 102 log files, 14 edm output root files, 25 DQM output files

[cmsbuild]

Pull request #20048 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22077/console Started: 2017/08/03 21:01

[cmsbuild]

+1
Tested at: d057524
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20048/22077/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
cf6d2ab
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20048/22077/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20048/22077/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Pull request #20048 was updated. @ghellwig, @civanch, @Dr15Jones, @arunhep, @ianna, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @lpernie can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22433/console Started: 2017/08/22 22:39

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20048/255

[cmsbuild]

+1
Tested at: 9a5f356
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20048/22433/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e739f38
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20048/22433/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20048/22433/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20048/22433/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2653934
• DQMHistoTests: Total failures: 294
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2653451
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[bsunanda]

@ianna @lpernie Could you approve this yet again - made change as suggested by David

[ianna]

+1

[lpernie]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1