Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GTUpdates_MagFieldMap_SiPixelQuality_CSC_ChannelStatus_HadPFUpdate_ESInterCalib #20067

Merged
merged 3 commits into from Aug 17, 2017
Merged

GTUpdates_MagFieldMap_SiPixelQuality_CSC_ChannelStatus_HadPFUpdate_ESInterCalib #20067

merged 3 commits into from Aug 17, 2017

Conversation

arunhep
Copy link
Contributor

@arunhep arunhep commented Aug 4, 2017

Summary of changes in Global Tags

RunI simulation

RunII simulation

MC 2017

Upgrade

RunI and RunII data

@cmsbuild cmsbuild added this to the CMSSW_9_3_X milestone Aug 4, 2017
@arunhep
Copy link
Contributor Author

arunhep commented Aug 4, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22108/console Started: 2017/08/05 03:31

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

A new Pull Request was created by @arunhep (Arun Kumar) for master.

It involves the following packages:

Configuration/AlCa

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @ghellwig, @tocheng this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@arunhep
Copy link
Contributor Author

arunhep commented Aug 4, 2017

assign reconstruction

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

New categories assigned: reconstruction

@slava77,@perrotta you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2017

-1

Tested at: 2c7bddc

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
909ea2f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20067/22108/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20067/22108/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20067/22108/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log
140.53 step2 
runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log
1003.0 step2 
runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log
1000.0 step2 
runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
1001.0 step2 
runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log
4.53 step3 
runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log
  • AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Sat Aug 5 04:43:27 2017-date Sat Aug 5 04:39:05 2017 s - exit: 16640

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
909ea2f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20067/22108/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20067/22108/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2017

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@arunhep
Copy link
Contributor Author

arunhep commented Aug 5, 2017

forgot renaming one GT.

@arunhep
Copy link
Contributor Author

arunhep commented Aug 5, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22109/console Started: 2017/08/05 07:54

@cmsbuild
Copy link
Contributor

Pull request #20067 was updated. @perrotta, @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @slava77, @lpernie can you please check and sign again.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20067/134

@arunhep
Copy link
Contributor Author

arunhep commented Aug 15, 2017 •
edited

Summary of changes in Global Tags

MC 2017

@franzoni
Copy link

unhold

@cmsbuild cmsbuild removed the hold label Aug 15, 2017
@lpernie
Copy link
Contributor

lpernie commented Aug 15, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 15, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22318/console Started: 2017/08/15 18:12
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22319/console Started: 2017/08/15 18:15

@cmsbuild
Copy link
Contributor

+1
Tested at: eba9a97
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20067/22319/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
7d6f190
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20067/22319/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20067/22319/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20067/22319/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 21026 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2718193
  • DQMHistoTests: Total failures: 120675
  • DQMHistoTests: Total nulls: 21
  • DQMHistoTests: Total successes: 2597308
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@slava77
Copy link
Contributor

slava77 commented Aug 16, 2017

+1

for #20067 eba9a97

  • updates since the last signoff were to add missing change in HCAL calibration for 2017 MC HcalRespCorrsRcd - HcalRespCorrs_2017plan1_v4.0_mc HcalRespCorrs_2017plan1_v5.0_mc
    • notably, the same payload for 2018 is some old HcalRespCorrs_2018_v2.0_mc (from Feb 16 of 2017). I guess it's too early to make 2018 more correct; otside of the scope of this PR.
  • jenkins tests pass
    • the old feature with low-pt photons is the same
    • the effect of the HCAL response change is not really visible due to changes in GEN-SIM

@franzoni
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d02b966 into cms-sw:master Aug 17, 2017
@prebello prebello mentioned this pull request Aug 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-available fully-signed orp-approved reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_3_X
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@arunhep @cmsbuild @slava77 @smuzaffar @spandeyehep @seemasharmafnal @franzoni @lpernie @davidlange6