Remove QuadrupletSeedMerger as obsolete #20127
Conversation
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: RecoHI/HiTracking @perrotta, @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @slava77, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
makortel
force-pushed
the
removeQuadrupletSeedMerger
branch
from
f4f592e
to
8acfcc5
Compare
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pr-code-checks/PR-20127/49 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/jenkins-artifacts/pr-code-checks/PR-20127/49/git-diff.patch In future, you can run |
|
-1 Tested at: 8acfcc5 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals AddOn
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log
I found errors in the following addon tests: cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Fri Aug 11 12:01:07 2017-date Fri Aug 11 11:56:56 2017 s - exit: 256 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
It looks like PixelLayerTriplets are still needed in HI reco... @makortel : while you are fixing it, you could also consider fixing what found by the code checker in #20127 (comment) |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-notrun
tests-rejected
labels
|
Pull request #20127 was updated. @perrotta, @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @slava77, @vanbesien can you please check and sign again. |
|
The tests are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pr-code-checks/PR-20127/56 |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This PR removes the obsolete QuadrupletSeedMerger algorithm (which created pixel quadruplet seeds by merging pixel triplets), and moves the quadruplet layer set configuration
quadrupletseedmerging_cffunderRecoTracker/TkSeedingLayerswith the namePixelLayerQuadruplets_cfffollowing the existing convention for pairs and triplets.Tested in 9_3_0_pre3, no changes expected.
@rovere @VinInn @ebrondol @felicepantaleo