Run2-alca90 Add a missing collection for Muons in HB/HE #20138
Conversation
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Calibration/HcalAlCaRecoProducers @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pr-code-checks/PR-20138/68 |
|
-1 Tested at: 0a44eef The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step5_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log136.731 step1 DAS Error The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
@cmsbuild Please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-notrun
tests-rejected
labels
|
The tests are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pr-code-checks/PR-20138/78 |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pr-code-checks/PR-20138/80 |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
Hi @bsunanda, could you summarize why the need of these muon collections? thanks. |
|
hi @lpernie did you really mean to +1 this PR? Perhaps your questions should be answered first? |
|
We have tested earlier that we need all these muon collections to make a selection of good muon candidates downstream for the final calibration. This was answered earlier in AlCaDb meetings. The only change from earlier time is to include pre-rechits. This collection comes from new strategy of HCAL reconstruction and one needs to work with uncollapsed as well as collapsed RecHits. This addition has increased the data volume requirement by 6%. The muon collection requirement has been there from beginning of 2016. |
|
Hi @davidlange6 , I'm sorry for inverting the order, I just wanted a confirmation (next time I will wait). |
|
merge |
Run2-hcx145 Change o/p definition for HBHEMuonFilter AlCaReco (Backport PR #20138)
No description provided.