Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimazing BMTF plots #20150

Merged
merged 2 commits into from Sep 15, 2017
Merged

optimazing BMTF plots #20150

merged 2 commits into from Sep 15, 2017

Conversation

gkaratha
Copy link
Contributor

Minor changes and corrections to BMTF plots. Smaller number of bins in some plots, phi correction and conditional for fat events

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 13, 2017

A new Pull Request was created by @gkaratha for CMSSW_9_2_X.

It involves the following packages:

DQM/L1TMonitor

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@kreczko, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor

Hi @gkaratha ,
please make also a PR to the master branch and mark this as a backport of it afterwards.

@gkaratha
Copy link
Contributor Author

Please consider this as a backport of 20185. Thanks

@thomreis
Copy link
Contributor

backport of #20185

1 similar comment
@gkaratha
Copy link
Contributor Author

backport of #20185

@cmsbuild
Copy link
Contributor

Pull request #20150 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22726/console Started: 2017/09/05 17:19

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

-1

Tested at: 3968980

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f538f01
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20150/22726/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20150/22726/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20150/22726/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
136.788 step2

runTheMatrix-results/136.788_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017/step2_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f538f01
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20150/22726/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20150/22726/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@dmitrijus
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22903/console Started: 2017/09/12 17:17

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20150/22903/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1904642
  • DQMHistoTests: Total failures: 15052
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 1889414
  • DQMHistoTests: Total skipped: 174
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 526bd63 into cms-sw:CMSSW_9_2_X Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants