Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PixelFed25 error propagation to tracking #20151

Merged
merged 12 commits into from Oct 2, 2017

Commits on Aug 14, 2017

  1. Created a new collection to describe a FED channel with FED number, l…

    …ink number, and the serial numbers of the first and last ROCs in the channel. Intend to list ROCs by the offline numbering scheme: an interval of N ROCs contained by [0, 15]. Also defined a collection as a DetSetVector. Overall information in the collection is sufficient to identify individual ROCs offline with DetId+ROC number.
    veszpv committed Aug 14, 2017
    Copy the full SHA
    f94f3be View commit details
    Browse the repository at this point in the history
  2. 1) Removed 'disabled FED channel' error (25) for disconnected FED cha…

    …nnels, improved error message. 2) Cleaned up decoding TBM trailer error type 30 (allow only 'number of ROCs' and 'overflow' errors being unpacked, 3) Let error to be assigned to DetId also in the FPix (since in Phase 1 -- as opposed to Phase 0 --, one channel transmits only from a single module)
    veszpv committed Aug 14, 2017
    Copy the full SHA
    918f76e View commit details
    Browse the repository at this point in the history
  3. Put back LogWarning in SiPixelFrameConverter::toRoc that was changed …

    …to LogDebug in order to suppress flood of warnings generated by decoding FED error 25 for disconnected channels
    veszpv committed Aug 14, 2017
    Copy the full SHA
    1b2c227 View commit details
    Browse the repository at this point in the history
  4. 1) Propagated cabling map to ErrorChecker to allow masking FED error …

    …type 25 generated by disconnected FED channels. 2) Exposed information in PixelDataFormatter on bit pattern decoding of error words to raw2digi. 3) Had raw2digi populate the PixelFEDChannelCollection with type 25 error channels
    veszpv committed Aug 14, 2017
    Copy the full SHA
    52ed124 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    aa06281 View commit details
    Browse the repository at this point in the history
  6. Populate PxMeasurementDetSet from PixelFEDChannelCollection per event…

    …. Feature is turned on by including badPixelFEDChannelCollectionLabels in MeasurementTrackerEventProducer_cfi.py; if so, also must add pixelCablingMapLabel
    veszpv committed Aug 14, 2017
    Copy the full SHA
    9c8105a View commit details
    Browse the repository at this point in the history
  7. Inactivate bad channels in hasBadComponents, where the inactive ROCs …

    …from SiPixelQuality are also applied.
    veszpv committed Aug 14, 2017
    Copy the full SHA
    c11c6c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2017

  1. Copy the full SHA
    e86c229 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2017

  1. Implemented comments

    veszpv committed Sep 26, 2017
    Copy the full SHA
    1a1fa22 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2017

  1. ran code-checks

    veszpv committed Sep 27, 2017
    Copy the full SHA
    8d2d883 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2017

  1. friends no more

    veszpv committed Sep 29, 2017
    Copy the full SHA
    ef534f3 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    b1e1541 View commit details
    Browse the repository at this point in the history