Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MonitorElement exception in L1TTau offline DQM. #20156

Conversation

thomreis
Copy link
Contributor

This fixes an exception that was found at the T0 replay.
Some simple copy and paste error.

Also fixes a wrong variable being filled in the histogram.

 ----- Begin Fatal Exception 12-Aug-2017 06:07:52 CEST-----------------------
 An exception of category 'MonitorElement' occurred while
    [0] Processing  Event run: 300811 lumi: 277 event: 473815345 stream: 3
    [1] Running path 'dqmofflineOnPAT_step'
    [2] Calling method for module L1TTauOffline/'l1tTauOfflineDQM'
 Exception Message:
 Method 'void MonitorElement::Fill(double)' cannot be invoked on monitor element  'L1TauETvsTauET_EE'
 ----- End Fatal Exception -------------------------------------------------

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

DQMOffline/L1Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn can you please review it and eventually sign? Thanks.
@kreczko, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pr-code-checks/PR-20156/94

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/jenkins-artifacts/pr-code-checks/PR-20156/94/git-diff.patch

In future, you can run scram build code-checks to apply code checks

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 14, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22278/console Started: 2017/08/14 14:41

@rekovic
Copy link
Contributor

rekovic commented Aug 14, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@rekovic
Copy link
Contributor

rekovic commented Aug 14, 2017

@thomreis
Can we please also have 92x version of this.

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 17b763e into cms-sw:master Aug 14, 2017
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20156/22278/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2713569
  • DQMHistoTests: Total failures: 256
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2713124
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@thomreis thomreis deleted the l1t_tau_offline_dqm_monitorelement_exception_fix branch August 30, 2017 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants