Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MonitorElement exception in L1TTau offline DQM. - 92x #20157

Conversation

thomreis
Copy link
Contributor

backport of #20156

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 14, 2017

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_9_2_X.

It involves the following packages:

DQMOffline/L1Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn can you please review it and eventually sign? Thanks.
@kreczko, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor

rekovic commented Aug 14, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 14, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22280/console Started: 2017/08/14 14:55

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20157/22280/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1792872
  • DQMHistoTests: Total failures: 15037
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1777669
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Aug 15, 2017

@thomreis
Originally merged Tau DQM Offline PR (#20043) been reverted in 92x, by a recent PR #20168

@davidlange6
I imagine that you would like a combo fixed version PR, i.e original PR + this PR, showing that it
passes the previously observed crashes.

@thomreis
Copy link
Contributor Author

@rekovic yes I saw it in 9_2_9_patch1. Now this PR has a conflict. What best to do about this?

@thomreis
Copy link
Contributor Author

Superseded by #20174

@thomreis thomreis closed this Aug 15, 2017
@thomreis thomreis deleted the l1t_tau_offline_dqm_monitorelement_exception_fix_92x branch August 30, 2017 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants