Run2-hcx144 Correct the active length calculation and its usage

[bsunanda]

Active length in scintillator is used for MIP calculation.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22327/console Started: 2017/08/15 22:23

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Calibration/HcalCalibAlgos
Geometry/HcalCommonData

@ghellwig, @civanch, @Dr15Jones, @arunhep, @ianna, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20179/146

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20179/146/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20179/146/git-diff.patch | patch -p1

In future, you can run scram build code-checks to apply code checks

[bsunanda]

@cmsbuild Please test

[cmsbuild]

Pull request #20179 was updated. @ghellwig, @civanch, @Dr15Jones, @arunhep, @ianna, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @lpernie can you please check and sign again.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20179/148

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20179/148/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20179/148/git-diff.patch | patch -p1

In future, you can run scram build code-checks to apply code checks

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22329/console Started: 2017/08/15 23:55

[cmsbuild]

+1
Tested at: d4ca38a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20179/22329/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
7d6f190
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20179/22329/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20179/22329/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20179/22329/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2718193
• DQMHistoTests: Total failures: 279
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2717725
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

Pull request #20179 was updated. @ghellwig, @civanch, @Dr15Jones, @arunhep, @ianna, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @lpernie can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22534/console Started: 2017/08/28 22:11

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20179/356

[cmsbuild]

+1
Tested at: 83019df
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20179/22534/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
566f40c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20179/22534/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20179/22534/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20179/22534/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2653934
• DQMHistoTests: Total failures: 216
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2653529
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[bsunanda]

@ianna @lpernie @arunhep @franzoni Please approve this PR

[lpernie]

+1

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1