Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PackedCandidate covariance issue #20197

Merged
merged 1 commit into from
Aug 18, 2017
Merged

Fix PackedCandidate covariance issue #20197

merged 1 commit into from
Aug 18, 2017

Conversation

weishi10141993
Copy link
Contributor

This was done in 92X, now do PR to the master: #20105

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @weishi10141993 for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @seemasharmafnal, @JyothsnaKomaragiri this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20197/183

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20197/183/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20197/183/git-diff.patch | patch -p1

In future, you can run scram build code-checks to apply code checks

@slava77
Copy link
Contributor

slava77 commented Aug 17, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22364/console Started: 2017/08/17 17:00

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20197/22364/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2653169
  • DQMHistoTests: Total failures: 218
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2652762
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@perrotta
Copy link
Contributor

+1

  • Already evaluated in 92X as Update TrackAndVertexUnpacker.cc #20114
  • Changes look reasonable
  • Reco sequences not affected: the modified class only enters some test config in the pat area
  • No changes expected in reco objects, no changes observed in jenkins tests outputs

@davidlange6
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants