Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TrackAndVertexUnpacker.cc #20114

Merged
merged 1 commit into from Aug 22, 2017
Merged

Update TrackAndVertexUnpacker.cc #20114

merged 1 commit into from Aug 22, 2017

Conversation

weishi10141993
Copy link
Contributor

Add "hasTrackDetails()" to Fix PackedCandidate covariance issue in TrackAndVertexUnpacker.cc

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 10, 2017

A new Pull Request was created by @weishi10141993 for CMSSW_9_2_X.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @seemasharmafnal, @JyothsnaKomaragiri this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Aug 10, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22194/console Started: 2017/08/10 16:31

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20114/22194/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1791842
  • DQMHistoTests: Total failures: 14966
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1776710
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@perrotta
Copy link
Contributor

+1

  • Changes look reasonable
  • Reco sequences not affected: the modified class only enters some test config in the pat area
  • No changes expected in reco objects, no changes observed in jenkins tests outputs

@perrotta
Copy link
Contributor

hold
Realizing only now that a 93X version of this PR was not done (I was convinced that I signed it in the master...): please @weishi10141993 provide a PR for the master!

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @perrotta
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Aug 17, 2017
@perrotta
Copy link
Contributor

backport of #20197

@perrotta
Copy link
Contributor

unhold
(since the identical version of this PR in the master has now being produced)

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 801ad34 into cms-sw:CMSSW_9_2_X Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants