Add muon filter sequence #20209
Add muon filter sequence #20209
Conversation
|
A new Pull Request was created by @kskovpen (skkywriter) for master. It involves the following packages: SimMuon/MCTruth @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+code-checks |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@kskovpen , is the filter active or passive by default? |
|
@civanch it becomes active once it is called by FILTER:SimMuon/MCTruth/SimMuFilter_cfi.SimMuFiltSeq in cmsDriver |
|
@kskovpen , i see many differences in comparison have they any relation to this PR? |
|
@civanch Could you please point me to one of the problematic plots ? In principle, this one line addition should be totally harmless. This filter module is not used by other modules in CMSSW. |
|
Thanks. To my knowledge, this PR can not affect anything. |
|
please test |
cmsbuild
added
comparison-pending
and removed
comparison-available
tests-approved
labels
|
|
||
| from SimMuon.MCTruth.SimMuFilter_cfi import SimMuFilter | ||
|
|
||
| SimMuFilter.nMuSel = 2 |
There was a problem hiding this comment.
hi @kskovpen - to change parameters of a module, you need to clone it ( to avoid conflicts).
eg,
SimMuFilter2Mu = SimMuFilter.clone()
SimMuFilter2Mu.nMuSel=2
|
The code-checks are being triggered in jenkins. |
|
Pull request #20209 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again. |
|
+code-checks |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
This PR represents a small update to the SIM muon filter implementation (#16849) to make it also available as a sequence. This allows one to use it directly in cmsDriver sequences for official MC production.