CTPPS pixel local rechits #20216

fabferro · 2017-08-21T12:06:09Z

Data formats and algorithm to create CTPPS pixel reconstructed hits in local (module) coordinates.

cmsbuild · 2017-08-21T12:06:31Z

A new Pull Request was created by @fabferro (Fabrizio Ferro) for master.

It involves the following packages:

DataFormats/CTPPSReco
RecoCTPPS/Configuration
RecoCTPPS/PixelLocal

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@forthommel this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2017-08-21T12:08:32Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20216/221

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20216/221/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20216/221/git-diff.patch | patch -p1

In future, you can run scram build code-checks to apply code checks

cmsbuild · 2017-08-21T12:26:54Z

Pull request #20216 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

cmsbuild · 2017-08-21T12:29:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20216/223

slava77 · 2017-08-21T12:55:32Z

@cmsbuild please test

cmsbuild · 2017-08-21T12:55:51Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22399/console Started: 2017/08/21 14:56

cmsbuild · 2017-08-21T14:23:33Z

+1
Tested at: e129a76
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20216/22399/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
1f919e0
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20216/22399/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20216/22399/git-merge-result

cmsbuild · 2017-08-21T14:23:36Z

Comparison job queued.

cmsbuild · 2017-08-21T15:57:10Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20216/22399/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2653934
DQMHistoTests: Total failures: 245
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2653500
DQMHistoTests: Total skipped: 189
DQMHistoTests: Total Missing objects: 0
Checked 107 log files, 14 edm output root files, 26 DQM output files

slava77 · 2017-08-28T14:05:51Z

RecoCTPPS/PixelLocal/interface/RPixClusterToHit.h

+
+private:
+
+  const edm::ParameterSet &params_;


I'm not sure this is safe to cache a ref to PSet

slava77 · 2017-08-28T14:06:23Z

DataFormats/CTPPSReco/interface/CTPPSPixelRecHit.h

+  CTPPSPixelRecHit(){}
+CTPPSPixelRecHit(LocalPoint lp, LocalError le) : thePoint(lp), theError(le), isOnEdge_(false),hasBadPixels_(false), spanTwoRocs_(false), minPixelRow_(0), minPixelCol_(0), clusterSize_(0), clusterSizeRow_(0), clusterSizeCol_(0){}
+CTPPSPixelRecHit(LocalPoint lp, LocalError le, bool edge, bool bad, bool rocs) : thePoint(lp), theError(le), isOnEdge_(edge),hasBadPixels_(bad), spanTwoRocs_(rocs),  minPixelRow_(0), minPixelCol_(0), clusterSize_(0), clusterSizeRow_(0), clusterSizeCol_(0){}
+CTPPSPixelRecHit(LocalPoint lp, LocalError le, bool edge, bool bad, bool rocs, int minrow, int mincol, int size, int rowsize, int colsize) : thePoint(lp), theError(le), isOnEdge_(edge),hasBadPixels_(bad), spanTwoRocs_(rocs),  minPixelRow_(minrow), minPixelCol_(mincol), clusterSize_(size), clusterSizeRow_(rowsize), clusterSizeCol_(colsize){}


line breaks please

cmsbuild · 2017-09-04T08:23:17Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-09-04T08:23:18Z

Pull request #20216 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

cmsbuild · 2017-09-04T08:25:11Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20216/475

perrotta · 2017-09-04T08:30:36Z

please test

cmsbuild · 2017-09-04T08:30:56Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22680/console Started: 2017/09/04 10:31

cmsbuild · 2017-09-04T09:39:08Z

+1
Tested at: 2e10735
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20216/22680/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
0770659
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20216/22680/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20216/22680/git-merge-result

cmsbuild · 2017-09-04T09:39:11Z

Comparison job queued.

perrotta · 2017-09-04T09:50:50Z

+1

Same as CTPPS pixel local rechits #20216 (comment)

cmsbuild · 2017-09-04T09:51:07Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2017-09-04T10:25:17Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20216/22680/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2656522
DQMHistoTests: Total failures: 208
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2656125
DQMHistoTests: Total skipped: 189
DQMHistoTests: Total Missing objects: 0
Checked 107 log files, 14 edm output root files, 26 DQM output files

davidlange6 · 2017-09-05T14:21:10Z

merge

ctpps pixel local rechits

73775ee

cmsbuild added this to the CMSSW_9_3_X milestone Aug 21, 2017

cmsbuild added comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Aug 21, 2017

committing changes to comply with code-check

e129a76

cmsbuild added tests-started and removed tests-pending labels Aug 21, 2017

cmsbuild added tests-approved and removed tests-started labels Aug 21, 2017

cmsbuild added comparison-available and removed comparison-pending labels Aug 21, 2017

smuzaffar added the code-checks-approved label Aug 22, 2017

slava77 reviewed Aug 28, 2017

View reviewed changes

fabferro added 2 commits August 28, 2017 16:41

line breaks for readability

bc888ff

removing caching of ref to pset

4683fff

cmsbuild removed code-checks-approved comparison-available labels Aug 28, 2017

cmsbuild added code-checks-pending comparison-pending pending-signatures reconstruction-pending tests-pending labels Sep 4, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 4, 2017

cmsbuild added tests-started and removed tests-pending labels Sep 4, 2017

cmsbuild added tests-approved and removed tests-started labels Sep 4, 2017

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Sep 4, 2017

cmsbuild added comparison-available and removed comparison-pending labels Sep 4, 2017

cmsbuild merged commit 2b50020 into cms-sw:master Sep 5, 2017

forthommel mentioned this pull request Sep 6, 2017

CTPPS: pixels geometry + geometry refactoring (9_2_X) #20018

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CTPPS pixel local rechits #20216

CTPPS pixel local rechits #20216

fabferro commented Aug 21, 2017

cmsbuild commented Aug 21, 2017

cmsbuild commented Aug 21, 2017

cmsbuild commented Aug 21, 2017

cmsbuild commented Aug 21, 2017

slava77 commented Aug 21, 2017

cmsbuild commented Aug 21, 2017 •

edited

cmsbuild commented Aug 21, 2017

cmsbuild commented Aug 21, 2017

cmsbuild commented Aug 21, 2017

slava77 Aug 28, 2017

fabferro Aug 28, 2017

slava77 Aug 28, 2017

fabferro Aug 28, 2017

cmsbuild commented Sep 4, 2017

cmsbuild commented Sep 4, 2017

cmsbuild commented Sep 4, 2017

perrotta commented Sep 4, 2017

cmsbuild commented Sep 4, 2017 •

edited

cmsbuild commented Sep 4, 2017

cmsbuild commented Sep 4, 2017

perrotta commented Sep 4, 2017

cmsbuild commented Sep 4, 2017

cmsbuild commented Sep 4, 2017

davidlange6 commented Sep 5, 2017

CTPPS pixel local rechits #20216

CTPPS pixel local rechits #20216

Conversation

fabferro commented Aug 21, 2017

cmsbuild commented Aug 21, 2017

cmsbuild commented Aug 21, 2017

cmsbuild commented Aug 21, 2017

cmsbuild commented Aug 21, 2017

slava77 commented Aug 21, 2017

cmsbuild commented Aug 21, 2017 • edited

cmsbuild commented Aug 21, 2017

cmsbuild commented Aug 21, 2017

cmsbuild commented Aug 21, 2017

slava77 Aug 28, 2017

Choose a reason for hiding this comment

fabferro Aug 28, 2017

Choose a reason for hiding this comment

slava77 Aug 28, 2017

Choose a reason for hiding this comment

fabferro Aug 28, 2017

Choose a reason for hiding this comment

cmsbuild commented Sep 4, 2017

cmsbuild commented Sep 4, 2017

cmsbuild commented Sep 4, 2017

perrotta commented Sep 4, 2017

cmsbuild commented Sep 4, 2017 • edited

cmsbuild commented Sep 4, 2017

cmsbuild commented Sep 4, 2017

perrotta commented Sep 4, 2017

cmsbuild commented Sep 4, 2017

cmsbuild commented Sep 4, 2017

davidlange6 commented Sep 5, 2017

cmsbuild commented Aug 21, 2017 •

edited

cmsbuild commented Sep 4, 2017 •

edited