Remove obsolete methods in SiStrip DQM that use subdetector-DetId classes #20223
Conversation
…(DQM/SiStripCommon)
…eclaration as well
|
A new Pull Request was created by @pieterdavid (Pieter David) for master. It involves the following packages: DQM/SiStripCommon @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+code-checks |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
SiStripFolderOrganizer::getFolderName(int32_t, std::string&)was deprecated, and is apparently not used anywhere in CMSSW - grep finds a few mentions of it, but they are commented out: DQMOffline/CalibTracker/interface/SiStripBaseServiceFromDQM.h, L163, and DQM/SiStripMonitorClient/src/SiStripInformationExtractor.cc L180, L328, and L365. We discussed with @fioriNTU , and it should be fine to remove this.std::string HDQMInspectorConfigSiStrip::translateDetId(const uint32_t) constseems not to be used anywhere - neither is the corresponding method inHDQMInspectorConfigTracking, so I would propose to remove both (together with the corresponding pure virtual method in the base class). In fact without these methods there is no difference betweenHDQMInspectorConfigSiStripandHDQMInspectorConfigTrackingany more - and I found no uses of anyHDQMInspectorConfig.*(except forHDQMInspectorConfigSiPixelhere, but I find no definition of that class, so that looks like an obsolete macro), so maybe these classes can be removed completely?CC: @OlivierBondu @alesaggio @vidalm ; tracked at #19398