Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a getByToken call in RecoTauTag/HLTProducers/src/CandidateSeededTrac... #2023

Merged
merged 1 commit into from
Jan 15, 2014

Conversation

perrotta
Copy link
Contributor

Fix a getByToken call in RecoTauTag/HLTProducers/src/CandidateSeededTrackingRegionsProducer.h
as noticed by Dominick Olivito in https://hypernews.cern.ch/HyperNews/CMS/get/hlt/3446.html

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta for CMSSW_7_0_X.

Fix a getByToken call in RecoTauTag/HLTProducers/src/CandidateSeededTrac...

It involves the following packages:

RecoTauTag/HLTProducers

@perrotta, @cmsbuild, @nclopezo, @Martin-Grunewald, @fwyzard, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@perrotta
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

-1
When I ran the RelVals I found an error in the following worklfows:
1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2023/2056/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes (but tests are reportedly failing). @ktf can you please take care of it?

@nclopezo
Copy link
Contributor

It seems to be a DAS glitch. I queued the tests for this pr again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes (tests are also fine). @ktf can you please take care of it?

@davidlange6
Copy link
Contributor

+1

ktf added a commit that referenced this pull request Jan 15, 2014
Consumes migration -- Fix a getByToken call in RecoTauTag/HLTProducers/src/CandidateSeededTrac...
@ktf ktf merged commit b82e92b into cms-sw:CMSSW_7_0_X Jan 15, 2014
@perrotta perrotta deleted the fixRecoTauTagHLTProducers branch March 5, 2014 08:19
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Move to ROOT pre-6.06 (almost final)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants