backport HLT developments from 9.2.x #20235
Conversation
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_9_0_X. It involves the following packages: DataFormats/EgammaReco @perrotta, @cmsbuild, @civanch, @vazzolini, @kmaeshima, @fwyzard, @mdhildreth, @dmitrijus, @Martin-Grunewald, @silviodonato, @slava77, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| * \author D.Chamont, U.Berthon, C.Charlot, LLR Palaiseau | ||
| * | ||
| ************************************************************/ | ||
| #ifndef DataFormats_EgammaReco_ElectronSeed_h |
There was a problem hiding this comment.
this file is probably the only change that triggers long recompilation.
There was a problem hiding this comment.
yes it is.
Unrelated to this there is a lot of other phaseI stuff needed to be compiled (its not just this E/gamma change which creates the situation David was complaining about).
|
so maybe we should see the full request before discussing further?
… On Aug 22, 2017, at 9:14 AM, Sam-Harper ***@***.***> wrote:
@Sam-Harper commented on this pull request.
In DataFormats/EgammaReco/interface/ElectronSeed.h:
> @@ -1,14 +1,38 @@
-#ifndef ElectronSeed_h
-#define ElectronSeed_h 1
-
-/** \class reco::ElectronSeed
- *
- * ElectronSeed is a seed for gsf tracking, constructed from
- * either a supercluster or a ctf track.
- *
- * \author D.Chamont, U.Berthon, C.Charlot, LLR Palaiseau
- *
- ************************************************************/
+#ifndef DataFormats_EgammaReco_ElectronSeed_h
yes it is.
Unrelated to this there is a lot of other phaseI stuff needed to be compiled (its not just this E/gamma change which creates the situation David was complaining about).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
If I understood correctly, this is the full request - it just is not only about E/Gamma. I can change the subject if you prefer, of course. |
|
Ah yes, there is more than just e/gamma here (I got confused from the title). I dont know what else is needed so wont comment on that. This has the e/gamma changes |
|
@fwyzard |
fwyzard
changed the title
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
What was the baseline in 92X for the backport and was it actually a backport (as parts of the diffs look like new developments)? I notice that the following do not exist in 92X or master and appear to be new developments that should be in master first
Then more:
|
|
@fwyzard @Sam-Harper |
|
@slava77 , sorry, no idea. I took the latest 92X /93X for the electron stuff but thats not what you're asking out. |
|
Looking more carefully, it looks like the author of other commits is Carlo. |
|
@fwyzard |
|
This is what was requested to further the HLT studies for Phase 2, based on the reports from @Sam-Harper @dsperka @battibass . If necessary, @gennai and marco.pieri@cern.ch can follow this up and comment further. |
|
Apart from repeating what has already written by Andrea (i.e. these are backporting needed for upgrade studies) I cannot say much more. |
1 similar comment
|
Apart from repeating what has already written by Andrea (i.e. these are backporting needed for upgrade studies) I cannot say much more. |
|
Hi all,
Said so, @fwyzard, how would you suggest to proceed (e.g. do you want me to get your branch, test the changes and make a PR to your github that you can integrate here)? |
|
[This is a weekly check.]
|
|
@battibass, I would suggest to
For the last point, you can start from my branch, but if I remember correctly all the changes came form you in the first place ? |
|
9.0.x è un typo spero ...
Best,
S.
Sent from a mobile phone
… Il giorno 19 set 2017, alle ore 19:14, Andrea Bocci ***@***.***> ha scritto:
@battibas, I would suggest to
make a PR for any missing functionality for the master/9.4.x release, and make sure everything works there
make a PR to backport any missing code to 9.3.x
make a PR to backport the same changes to 9.0.x
For the last point, you can start from my branch, but if I remember correctly all the changes came form you in the first place ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
ping, just as a weekly check |
|
-1 to take this off the list of PRs that need imminent attention |
|
-1 |
No description provided.