Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update of autoCond to include L1Menu_Collisions2017_v3_m6_xml in 8 GTs #20239

Merged
merged 1 commit into from Aug 30, 2017

Conversation

lpernie
Copy link
Contributor

@lpernie lpernie commented Aug 22, 2017

PR to master that includes a single change to autocond.py
8 GTs have been changes in such a way that now we use the L1T menu V3.
Deatails in:
https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/3001/2/1.html
Backport of: #20238

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 22, 2017

A new Pull Request was created by @lpernie (Luca) for CMSSW_9_2_X.

It involves the following packages:

Configuration/AlCa

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @ghellwig, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@lpernie
Copy link
Contributor Author

lpernie commented Aug 22, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 22, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22431/console Started: 2017/08/22 21:22

@lpernie
Copy link
Contributor Author

lpernie commented Aug 22, 2017

backport of #20238

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20239/22431/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1791808
  • DQMHistoTests: Total failures: 29449
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1762193
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@franzoni
Copy link

@lpernie
no changes in HLT DQM histograms in 2017 MC.
We gather this is expected, being the new L1T menu compatible with the HLT menu which is unchanged.
@Martin-Grunewald , do you concur?

@franzoni
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@Martin-Grunewald
Copy link
Contributor

Yes!

@Martin-Grunewald
Copy link
Contributor

Yes, compared to the previous V2 L1T menu L1Menu_Collisions2017_v2_m6_full_xml, the new V3 L1T menu L1Menu_Collisions2017_v3_m6_xml contains additional L1T triggers and does not remove any.

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0cfb51b into cms-sw:CMSSW_9_2_X Aug 30, 2017
@Martin-Grunewald
Copy link
Contributor

@lpernie
It seems this PR does not include the corresponding update of the GT key run2_hlt_relval.
Could you please make a PR with it?
Thanks!

@lpernie
Copy link
Contributor Author

lpernie commented Sep 5, 2017

Hi @Martin-Grunewald.
I have changed L1Menu_Collisions2017_v2_m6_full_xml with L1Menu_Collisions2017_v3_m6_xml.
Since in 92X_dataRun2_HLT_relval_Queue the TAG L1Menu_Collisions2017_v2_m6_full_xml was not approved yet, I miss it.
I'm creating now a PR in 92X with the change: #20381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants