Fix the histogram: RPC_HV_Status

[slezki]

Fixed the LS limitation for the histogram: RPC_HV_Status,
@jhgoh @mileva @andresib

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

A new Pull Request was created by @slezki for master.

It involves the following packages:

DQM/RPCMonitorClient

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@acimmino this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20245/268

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20245/268/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20245/268/git-diff.patch | patch -p1

In future, you can run scram build code-checks to apply code checks

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

Pull request #20245 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20245/278

[jhgoh]

The "RPC_HV_Status" in the RPC DQM is to show the number of LS with RPC, but it is limited not to exceed 900. This can cause confusion to shifters because of mismatch between the actual nLS of good RPC status and what is shown in the DQM.

We asked the reason of this limitation to the previous developer. It is to limit memory usage when the development was made. Size of memory can be increased for very long runs which can be nLS~2000 and the member variable "DCS" can be increased (type is std::vector). The memory usage for this vector should not be a major factor of the cmssw.

[dmitrijus]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22560/console Started: 2017/08/29 15:34

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1
Tested at: 5367ba0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20245/22560/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f91659f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20245/22560/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20245/22560/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20245/22560/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2653934
• DQMHistoTests: Total failures: 203
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2653542
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[davidlange6]

+1

[jhgoh]

Thanks @davidlange6